Page MenuHomePhabricator

Burnup report showing decimals on hover
ClosedPublic

Authored by guywarner on Jan 27 2014, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 19 2025, 11:54 PM
Unknown Object (File)
Jun 15 2025, 10:02 PM
Unknown Object (File)
Jun 15 2025, 4:34 PM
Unknown Object (File)
Jun 15 2025, 1:08 PM
Unknown Object (File)
Jun 14 2025, 9:18 PM
Unknown Object (File)
Jun 2 2025, 10:37 AM
Unknown Object (File)
May 20 2025, 5:32 AM
Unknown Object (File)
May 20 2025, 4:06 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2721aa272b48: Burnup report showing decimals on hover
Summary

Added yformat to ManiphestReportController. Removed [yy] from the js.
Will pull config.yformat or send []. The old way with [yy] never seemed to worked having config.yformat, also would crash if yformat was in with value

Test Plan

Loadup burn up report, hover over a given date. Number of tasks opened should be an int

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Lints fine locally, seems to work.

$ arc lint
 OKAY  No lint warnings.

I think format() must have taken a list before, the config.yformat || [] seems wrong too (e.g., should just be config.yformat. I'll fix that in th epull.