Page MenuHomePhabricator

Burnup report showing decimals on hover
ClosedPublic

Authored by guywarner on Jan 27 2014, 9:46 PM.
Tags
None
Referenced Files
F15491378: D8080.id.diff
Sat, Apr 12, 2:40 AM
F15438376: D8080.id.diff
Wed, Mar 26, 12:25 AM
F15438375: D8080.id18279.diff
Wed, Mar 26, 12:25 AM
F15438374: D8080.id18280.diff
Wed, Mar 26, 12:25 AM
F15423091: D8080.id.diff
Sat, Mar 22, 12:50 PM
F15409001: D8080.id18280.diff
Wed, Mar 19, 2:38 AM
F15397803: D8080.id18279.diff
Sun, Mar 16, 10:22 PM
F15387800: D8080.id.diff
Sat, Mar 15, 2:56 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2721aa272b48: Burnup report showing decimals on hover
Summary

Added yformat to ManiphestReportController. Removed [yy] from the js.
Will pull config.yformat or send []. The old way with [yy] never seemed to worked having config.yformat, also would crash if yformat was in with value

Test Plan

Loadup burn up report, hover over a given date. Number of tasks opened should be an int

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Lints fine locally, seems to work.

$ arc lint
 OKAY  No lint warnings.

I think format() must have taken a list before, the config.yformat || [] seems wrong too (e.g., should just be config.yformat. I'll fix that in th epull.