Paths

Table of Contentst

Differential D8072

Update DifferentialDiff: add repositoryPHID, drop parentRevisionID
ClosedPublic
Actions

Authored by epriestley on Jan 26 2014, 5:18 PM.

Tags

None

Referenced Files

	F19842139: D8072.diff
	Wed, Mar 11, 9:33 PM

	F19821902: D8072.diff
	Sat, Mar 7, 1:40 AM

	F19814251: D8072.id18264.diff
	Wed, Mar 4, 1:06 PM

	F19507018: D8072.id18263.diff
	Jan 9 2026, 5:10 PM

	F19506280: D8072.id18264.diff
	Jan 9 2026, 4:43 PM

	F19241480: D8072.id18263.diff
	Dec 21 2025, 10:34 PM

	F18984688: D8072.diff
	Nov 17 2025, 12:16 PM

	F18926127: D8072.id.diff
	Nov 9 2025, 7:23 PM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP014a873773eb: Update DifferentialDiff: add repositoryPHID, drop parentRevisionID

Summary

Moves away from ArcanistProjects:

Adds storage for diffs to be directly associated with a repository (instead of indirectly, through arcanist projects). Not really populated yet.
Drops parentRevisionID, which is obsoleted by the "Depends On" edge. This is not exposed in the UI anywhere and doesn't do anything. Resolves TODO.

Test Plan

Ran storage upgrades, browsed around, lots of grep.

Diff Detail

Branch

diff1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/conduit/ConduitAPI_differential_creatediff_Method.php:59	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

Also deprecate authorPHID, which isn't respected and is inauthentic.
Also deprecate repositoryUUID, which is redundant. Keep some traces of it around for compatibility.
Add UUID lookup, which is useful for SVN and can completely obsolete the older mechanism.

btrahan accepted this revision.Jan 26 2014, 11:10 PM

Closed by commit rP014a873773eb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140126.diff.1.parentrevisionid.sql

2 lines

20140126.diff.2.repositoryphid.sql

2 lines

src/

applications/

differential/

conduit/

ConduitAPI_differential_creatediff_Method.php

44 lines

storage/

DifferentialDiff.php

3 lines

repository/

conduit/

ConduitAPI_repository_query_Method.php

6 lines

Diff 18264

resources/sql/autopatches/20140126.diff.1.parentrevisionid.sql

Loading...

resources/sql/autopatches/20140126.diff.2.repositoryphid.sql

Loading...

src/applications/differential/conduit/ConduitAPI_differential_creatediff_Method.php

Loading...

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/repository/conduit/ConduitAPI_repository_query_Method.php

Loading...