Paths

Table of Contentst

Differential D8072

Update DifferentialDiff: add repositoryPHID, drop parentRevisionID
ClosedPublic
Actions

Authored by epriestley on Jan 26 2014, 5:18 PM.

Tags

None

Referenced Files

	F16305311: D8072.id18263.diff
	Sun, Jun 15, 11:59 AM

	Unknown Object (File)
	Thu, Jun 5, 9:37 PM

	Unknown Object (File)
	Sun, Jun 1, 5:39 AM

	Unknown Object (File)
	Sat, May 31, 5:56 AM

	Unknown Object (File)
	Fri, May 30, 7:16 PM

	Unknown Object (File)
	Thu, May 29, 12:51 PM

	Unknown Object (File)
	Wed, May 28, 5:11 PM

	Unknown Object (File)
	May 9 2025, 10:34 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP014a873773eb: Update DifferentialDiff: add repositoryPHID, drop parentRevisionID

Summary

Moves away from ArcanistProjects:

Adds storage for diffs to be directly associated with a repository (instead of indirectly, through arcanist projects). Not really populated yet.
Drops parentRevisionID, which is obsoleted by the "Depends On" edge. This is not exposed in the UI anywhere and doesn't do anything. Resolves TODO.

Test Plan

Ran storage upgrades, browsed around, lots of grep.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Also deprecate authorPHID, which isn't respected and is inauthentic.
Also deprecate repositoryUUID, which is redundant. Keep some traces of it around for compatibility.
Add UUID lookup, which is useful for SVN and can completely obsolete the older mechanism.

btrahan accepted this revision.Jan 26 2014, 11:10 PM

Closed by commit rP014a873773eb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140126.diff.1.parentrevisionid.sql

2 lines

20140126.diff.2.repositoryphid.sql

2 lines

src/

applications/

differential/

conduit/

ConduitAPI_differential_creatediff_Method.php

44 lines

storage/

DifferentialDiff.php

3 lines

repository/

conduit/

ConduitAPI_repository_query_Method.php

6 lines

Diff 18271

resources/sql/autopatches/20140126.diff.1.parentrevisionid.sql

Loading...

resources/sql/autopatches/20140126.diff.2.repositoryphid.sql

Loading...

src/applications/differential/conduit/ConduitAPI_differential_creatediff_Method.php

Loading...

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/repository/conduit/ConduitAPI_repository_query_Method.php

Loading...