Paths

Table of Contentst

Actually check CSRF on Password and LDAP forms
ClosedPublic
Actions

Authored by epriestley on Jan 23 2014, 10:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 12:16 PM

	Unknown Object (File)
	Sun, Dec 15, 12:16 PM

	Unknown Object (File)
	Sun, Dec 15, 12:16 PM

	Unknown Object (File)
	Thu, Dec 12, 9:25 AM

	Unknown Object (File)
	Wed, Dec 11, 8:48 AM

	Unknown Object (File)
	Mon, Dec 2, 4:25 PM

	Unknown Object (File)
	Tue, Nov 26, 6:19 PM

	Unknown Object (File)
	Thu, Nov 21, 8:44 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4339: Support CSRF for logged-out users

Commits

Restricted Diffusion Commit
rPfebc494737be: Actually check CSRF on Password and LDAP forms

Summary

Ref T4339. We didn't previously check isFormPost() on these, but now should.

Test Plan

Changed csrf token on login, got kicked out.

Diff Detail

Branch

csrfx

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/auth/provider/PhabricatorAuthProviderLDAP.php:160	XHP16	TODO Comment
Advice	src/applications/auth/provider/PhabricatorAuthProviderLDAP.php:171	XHP16	TODO Comment

Unit

No Test Coverage

Event Timeline

chad accepted this revision.Jan 23 2014, 10:17 PM

thx u :3

Closed by commit rPfebc494737be (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

provider/

PhabricatorAuthProviderLDAP.php

38 lines

PhabricatorAuthProviderPassword.php

33 lines

Diff 18214

View Options

src/applications/auth/provider/PhabricatorAuthProviderLDAP.php