Add dates to notifications page
ClosedPublic
Actions

Authored by chad on Jan 22 2014, 11:32 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T3957: Add timestamp to Notifications

Commits

Restricted Diffusion Commit
rP57f1a8348861: Add dates to notifications page

Summary

Fixes T3957, adds timestamps to the notifications page.

Test Plan

View my notifications page, see the new time stamps. Uncertain if I set $user correctly.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

{F103953}

What do you think about having the timestamps right aligned? I am notchad as well so not sure if this is a good idea or not.

I don’t visually have a preference overall. It’s more CSS because of mobile, but that’s like 2 more lines.

Well, if you don't care, can we go right align? I like it a little better and it seems to be slightly more standardish with things like the differential home page.

(prolly should have just approved in the first place)

dancingdoctor

doctordance

sweet macro bro

Yeah, I don’t see any easy way to do this across devices actually without a bit of hokeyness. If I float: left, it works on all devices consistently. If I float right, I have to hide a left floated div anyways to display on mobile. I might just stay with the easy solution for now (left align) and worry about something magical down the road.