Allow arc project and branch showing up in diff emails
ClosedPublic
Actions

Authored by • sowedance on Jan 22 2014, 1:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 24, 8:44 PM

	Unknown Object (File)
	Sun, Apr 21, 3:59 PM

	Unknown Object (File)
	Sun, Apr 21, 5:33 AM

	Unknown Object (File)
	Wed, Apr 17, 2:10 PM

	Unknown Object (File)
	Thu, Apr 11, 4:31 AM

	Unknown Object (File)
	Thu, Apr 11, 4:31 AM

	Unknown Object (File)
	Thu, Apr 11, 4:31 AM

	Unknown Object (File)
	Thu, Apr 11, 4:07 AM

Subscribers

Details

Reviewers

epriestley
lifeihuang
JoelB
raguiar

Commits

Restricted Diffusion Commit
rPc5c9cd415d89: Allow arc project and branch showing up in diff emails

Summary

Add the arc project and branch fields in emails for revisions under review. I am not quite sure why we only show them for changes which is already accepted or needs revision. It would be nice to have them for changes under review too.

Test Plan

Create a new revision and check email

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

We're moving away from arc projects, but I don't think there's much sense in having these clauses in either field. Let's just remove this special-casing entirely?

Remove the cases entirely.

Closed by commit rPc5c9cd415d89 (authored by @sowedance, committed by @epriestley).

Analiza

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

field/

specification/

DifferentialArcanistProjectFieldSpecification.php

7 lines

DifferentialBranchFieldSpecification.php

7 lines

Diff 18183

View Options

src/applications/differential/field/specification/DifferentialArcanistProjectFieldSpecification.php