Mostly align parser to PHP 5.5.8
ClosedPublic
Actions

Authored by epriestley on Jan 21 2014, 9:35 PM.

Details

Reviewers

btrahan
Firehed

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Commits

rPHU86d651f9c929: Mostly align parser to PHP 5.5.8

Summary

Ref T4334. Adds support for: traits; yield; short array syntax; callable; finally.

Test Plan

Unit tests. Attempted to use PHPAST web view to verify I didn't build the trees wrong.

{F103626}

Generally, these changes are difficult to verify by inspection, and errors only become clear once the tree is in use. So probably not everything is quite correct, but it should be relatively close.

Diff Detail

Branch

ast9

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	support/xhpast/parser.y:564	TXT3	Line Too Long

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Jan 21 2014, 10:25 PM

Closed by commit rPHU86d651f9c929 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

php-callable-typehint.php.expect

4 lines

php-callable-typehint.php.test

2 lines

	php-finally.php.expect
	php-callable-typehint.php.expect

100 lines

php-finally.php.test

2 lines

php-literal-index.php.expect

155 lines

php-literal-index.php.test

2 lines

php-short-array.php.expect

60 lines

php-short-array.php.test

2 lines

php-syntax.php.expect

6 lines

php-traits.php.expect

907 lines

php-traits.php.test

2 lines

php-yield.php.expect

433 lines

php-yield.php.test

2 lines

bin/

xhpast_parse.php

2 lines

parser_nodes.php

8 lines

parser_tokens.php

6 lines

support/

xhpast/

9 lines

202 lines

4 lines

5535 lines

9 lines

1 line

2 lines

1701 lines

2 lines

Diff 18156

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.test

View Options

src/parser/xhpast/tests/data/php-finally.php.expect

View Options

src/parser/xhpast/tests/data/php-finally.php.test

View Options

src/parser/xhpast/tests/data/php-literal-index.php.expect

View Options

src/parser/xhpast/tests/data/php-literal-index.php.test

View Options

src/parser/xhpast/tests/data/php-short-array.php.expect

View Options

src/parser/xhpast/tests/data/php-short-array.php.test

View Options

src/parser/xhpast/tests/data/php-syntax.php.expect

View Options

src/parser/xhpast/tests/data/php-traits.php.expect

View Options

src/parser/xhpast/tests/data/php-traits.php.test

View Options

src/parser/xhpast/tests/data/php-yield.php.expect

View Options

src/parser/xhpast/tests/data/php-yield.php.test

View Options

src/parser/xhpast/bin/xhpast_parse.php

View Options

src/parser/xhpast/parser_nodes.php

View Options

src/parser/xhpast/parser_tokens.php

View Options

support/xhpast/generate_nodes.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.hpp

View Options

support/xhpast/parser.yacc.cpp

View Options

support/xhpast/parser_nodes.php

View Options

support/xhpast/scanner.l

View Options

support/xhpast/scanner.lex.hpp

View Options

support/xhpast/scanner.lex.cpp

View Options

Mostly align parser to PHP 5.5.8ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18156

src/parser/xhpast/__tests__/data/php-callable-typehint.php.expect

src/parser/xhpast/__tests__/data/php-callable-typehint.php.test

src/parser/xhpast/__tests__/data/php-finally.php.expect

src/parser/xhpast/__tests__/data/php-finally.php.test

src/parser/xhpast/__tests__/data/php-literal-index.php.expect

src/parser/xhpast/__tests__/data/php-literal-index.php.test

src/parser/xhpast/__tests__/data/php-short-array.php.expect

src/parser/xhpast/__tests__/data/php-short-array.php.test

src/parser/xhpast/__tests__/data/php-syntax.php.expect

src/parser/xhpast/__tests__/data/php-traits.php.expect

src/parser/xhpast/__tests__/data/php-traits.php.test

src/parser/xhpast/__tests__/data/php-yield.php.expect

src/parser/xhpast/__tests__/data/php-yield.php.test

src/parser/xhpast/bin/xhpast_parse.php

src/parser/xhpast/parser_nodes.php

src/parser/xhpast/parser_tokens.php

support/xhpast/generate_nodes.php

support/xhpast/parser.y

support/xhpast/parser.yacc.hpp

support/xhpast/parser.yacc.cpp

support/xhpast/parser_nodes.php

support/xhpast/scanner.l

support/xhpast/scanner.lex.hpp

support/xhpast/scanner.lex.cpp

support/xhpast/xhpast.cpp

Mostly align parser to PHP 5.5.8
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/php-callable-typehint.php.expect

src/parser/xhpast/tests/data/php-callable-typehint.php.test

src/parser/xhpast/tests/data/php-finally.php.expect

src/parser/xhpast/tests/data/php-finally.php.test

src/parser/xhpast/tests/data/php-literal-index.php.expect

src/parser/xhpast/tests/data/php-literal-index.php.test

src/parser/xhpast/tests/data/php-short-array.php.expect

src/parser/xhpast/tests/data/php-short-array.php.test

src/parser/xhpast/tests/data/php-syntax.php.expect

src/parser/xhpast/tests/data/php-traits.php.expect

src/parser/xhpast/tests/data/php-traits.php.test

src/parser/xhpast/tests/data/php-yield.php.expect

src/parser/xhpast/tests/data/php-yield.php.test