Paths

Table of Contentst

Add a PHPAST test case for most of the PHP grammar
ClosedPublic
Actions

Authored by epriestley on Jan 21 2014, 6:19 PM.

Tags

None

Referenced Files

	F13162151: D8028.diff
	Mon, May 6, 12:21 PM

	Unknown Object (File)
	Sun, May 5, 4:11 PM

	Unknown Object (File)
	Wed, May 1, 7:09 PM

	Unknown Object (File)
	Wed, May 1, 9:32 AM

	Unknown Object (File)
	Sat, Apr 20, 6:19 PM

	Unknown Object (File)
	Tue, Apr 16, 3:16 PM

	Unknown Object (File)
	Tue, Apr 16, 12:11 AM

	Unknown Object (File)
	Tue, Apr 9, 3:28 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
Firehed

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Commits

rPHU74999552f0cc: Add a PHPAST test case for most of the PHP grammar

Summary

Ref T4334. This test case covers most of the common PHP grammar rules. It's not exhastive and avoids some of the tricky parts, but provides a wide base of rule tests.

Test Plan

Examined parse manually in PHPAST web tool. Ran unit tests.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley added inline comments.Jan 21 2014, 6:25 PM

src/parser/xhpast/__tests__/data/php-syntax.php.test
118–119	always do this it is a good idea

btrahan accepted this revision.Jan 21 2014, 10:18 PM

btrahan added inline comments.

src/parser/xhpast/__tests__/data/php-syntax.php.test
118–119	what the heck should this do?
207	what does this do?

epriestley added inline comments.Jan 21 2014, 10:23 PM

src/parser/xhpast/__tests__/data/php-syntax.php.test
118–119	fire the author
207	I think it always returns `null`, but honestly I don't know.

Closed by commit rPHU74999552f0cc (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

php-syntax.php.expect

11084 lines

php-syntax.php.test

219 lines

Diff 18172

View Options

src/parser/xhpast/tests/data/php-syntax.php.expect

View Options

src/parser/xhpast/tests/data/php-syntax.php.test

Add a PHPAST test case for most of the PHP grammarClosedPublicActions