Make directory fixture script slightly more modern and usable
ClosedPublic
Actions

Authored by epriestley on Jan 21 2014, 3:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 7, 8:21 AM

	Unknown Object (File)
	Wed, Dec 4, 10:30 AM

	Unknown Object (File)
	Wed, Dec 4, 3:50 AM

	Unknown Object (File)
	Fri, Nov 29, 1:37 AM

	Unknown Object (File)
	Wed, Nov 27, 7:13 PM

	Unknown Object (File)
	Tue, Nov 26, 2:44 PM

	Unknown Object (File)
	Wed, Nov 20, 2:43 AM

	Unknown Object (File)
	Sat, Nov 16, 12:45 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4327: Problems trying to import project

Commits

rPHU6ee25dfe7db5: Make directory fixture script slightly more modern and usable

Summary

Ref T4327. I made some small changes to this script while developing parser unit tests. Mostly:

Add pht().
Use PhutilConsole.
Throw PhutilArugmentUsageException for questionable usage.
Add a --read-only flag to ignore changes on exit.
Show the CWD after unpacking the fixture, which makes it easier to svn checkout file://... it.
Improve some language.

Test Plan

Tested all the features; used these features while working on T4327 to good effect.

Diff Detail

Branch

dfix

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Jan 21 2014, 9:50 PM

Closed by commit rPHU6ee25dfe7db5 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

utils/

directory_fixture.php

53 lines

Diff 18142

View Options

scripts/utils/directory_fixture.php

Make directory fixture script slightly more modern and usableClosedPublicActions