Page MenuHomePhabricator

Make directory fixture script slightly more modern and usable
ClosedPublic

Authored by epriestley on Jan 21 2014, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 9:50 PM
Unknown Object (File)
Mon, Apr 22, 8:37 PM
Unknown Object (File)
Sun, Apr 21, 3:52 PM
Unknown Object (File)
Sat, Apr 20, 6:18 PM
Unknown Object (File)
Thu, Apr 18, 11:10 PM
Unknown Object (File)
Wed, Apr 17, 2:56 PM
Unknown Object (File)
Wed, Apr 17, 2:07 AM
Unknown Object (File)
Tue, Apr 16, 12:12 AM
Subscribers

Details

Summary

Ref T4327. I made some small changes to this script while developing parser unit tests. Mostly:

  • Add pht().
  • Use PhutilConsole.
  • Throw PhutilArugmentUsageException for questionable usage.
  • Add a --read-only flag to ignore changes on exit.
  • Show the CWD after unpacking the fixture, which makes it easier to svn checkout file://... it.
  • Improve some language.
Test Plan

Tested all the features; used these features while working on T4327 to good effect.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped