Page MenuHomePhabricator

Make directory fixture script slightly more modern and usable
ClosedPublic

Authored by epriestley on Jan 21 2014, 3:34 PM.
Tags
None
Referenced Files
F15578917: D8021.diff
Tue, May 6, 9:38 PM
F15549267: D8021.id18142.diff
Sun, Apr 27, 4:45 AM
F15529589: D8021.id.diff
Tue, Apr 22, 9:03 PM
F15528492: D8021.id18165.diff
Tue, Apr 22, 11:31 AM
F15525900: D8021.diff
Mon, Apr 21, 5:41 PM
F15515129: D8021.id18165.diff
Fri, Apr 18, 7:49 AM
F15507929: D8021.diff
Wed, Apr 16, 12:20 AM
F15491112: D8021.id18142.diff
Fri, Apr 11, 11:42 PM
Subscribers

Details

Summary

Ref T4327. I made some small changes to this script while developing parser unit tests. Mostly:

  • Add pht().
  • Use PhutilConsole.
  • Throw PhutilArugmentUsageException for questionable usage.
  • Add a --read-only flag to ignore changes on exit.
  • Show the CWD after unpacking the fixture, which makes it easier to svn checkout file://... it.
  • Improve some language.
Test Plan

Tested all the features; used these features while working on T4327 to good effect.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped