Page MenuHomePhabricator

Make directory fixture script slightly more modern and usable
ClosedPublic

Authored by epriestley on Jan 21 2014, 3:34 PM.
Tags
None
Referenced Files
F15434755: D8021.id18142.diff
Tue, Mar 25, 5:12 AM
F15427506: D8021.id18142.diff
Sun, Mar 23, 2:44 PM
F15408442: D8021.id.diff
Tue, Mar 18, 11:05 PM
F15406648: D8021.id18165.diff
Tue, Mar 18, 1:07 PM
F15401913: D8021.diff
Mon, Mar 17, 7:46 PM
F15400312: D8021.id18142.diff
Mon, Mar 17, 10:56 AM
F15381243: D8021.id18165.diff
Fri, Mar 14, 6:39 AM
Unknown Object (File)
Mon, Mar 3, 9:58 AM
Subscribers

Details

Summary

Ref T4327. I made some small changes to this script while developing parser unit tests. Mostly:

  • Add pht().
  • Use PhutilConsole.
  • Throw PhutilArugmentUsageException for questionable usage.
  • Add a --read-only flag to ignore changes on exit.
  • Show the CWD after unpacking the fixture, which makes it easier to svn checkout file://... it.
  • Improve some language.
Test Plan

Tested all the features; used these features while working on T4327 to good effect.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped