Page MenuHomePhabricator

Remarkup - add underline rule
ClosedPublic

Authored by btrahan on Jan 17 2014, 8:54 PM.
Tags
None
Referenced Files
F15416287: D7995.id18093.diff
Thu, Mar 20, 10:19 AM
F15407998: D7995.id.diff
Tue, Mar 18, 8:44 PM
F15406150: D7995.id18091.diff
Tue, Mar 18, 12:10 PM
F15399456: D7995.diff
Mon, Mar 17, 4:38 AM
F15349774: D7995.diff
Mon, Mar 10, 3:07 PM
F15308369: D7995.id.diff
Mar 6 2025, 6:12 AM
Unknown Object (File)
Feb 24 2025, 11:24 AM
Unknown Object (File)
Feb 11 2025, 1:48 PM

Details

Summary

...and a test even!

Test Plan

tests passed

Diff Detail

Branch
foo
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/markup/engine/__tests__/remarkup/underline.txt:11TXT3Line Too Long
Unit
Tests Passed

Event Timeline

This is bold in Markdown and will probably get occasional false postiives on __init__.py and such, but I think it's the most logical syntax.

Maybe it's worth using this negative lookbehind prefix (instead of (?<!_)), to avoid matching /__tests__/ and /__init__.py (i.e., "__" is not valid after "/" or "_"):

(?<!_|/)

...and this suffix, for the same cases:

(?!/|\.\S)

(i.e., "__" is not valid before ".x" or "/").

Will update and send out a new diff once I am sure it works... I readily admit my regex foo is yellow belt at best. =D