Page MenuHomePhabricator

Remarkup - add underline rule
ClosedPublic

Authored by btrahan on Jan 17 2014, 8:54 PM.
Tags
None
Referenced Files
F13229079: D7995.diff
Mon, May 20, 2:14 PM
F13191225: D7995.diff
Sat, May 11, 6:06 PM
F13183189: D7995.id.diff
Fri, May 10, 7:24 AM
Unknown Object (File)
Apr 18 2024, 11:10 PM
Unknown Object (File)
Apr 17 2024, 2:07 AM
Unknown Object (File)
Apr 16 2024, 12:12 AM
Unknown Object (File)
Apr 8 2024, 12:05 AM
Unknown Object (File)
Apr 7 2024, 6:11 AM

Details

Summary

...and a test even!

Test Plan

tests passed

Diff Detail

Branch
foo
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/markup/engine/__tests__/remarkup/underline.txt:11TXT3Line Too Long
Unit
Tests Passed

Event Timeline

This is bold in Markdown and will probably get occasional false postiives on __init__.py and such, but I think it's the most logical syntax.

Maybe it's worth using this negative lookbehind prefix (instead of (?<!_)), to avoid matching /__tests__/ and /__init__.py (i.e., "__" is not valid after "/" or "_"):

(?<!_|/)

...and this suffix, for the same cases:

(?!/|\.\S)

(i.e., "__" is not valid before ".x" or "/").

Will update and send out a new diff once I am sure it works... I readily admit my regex foo is yellow belt at best. =D