Page MenuHomePhabricator

Call willLintPath() hook from PhutilLinter
ClosedPublic

Authored by epriestley on Jan 17 2014, 1:50 AM.
Tags
None
Referenced Files
F14012783: D7988.diff
Fri, Nov 1, 6:20 PM
F14009531: D7988.id18112.diff
Wed, Oct 30, 7:41 PM
F14009256: D7988.id18112.diff
Wed, Oct 30, 1:37 PM
F14007481: D7988.id18112.diff
Tue, Oct 29, 6:32 AM
F14003048: D7988.id18112.diff
Sat, Oct 26, 1:32 AM
F13988911: D7988.diff
Mon, Oct 21, 4:40 PM
F13975467: D7988.diff
Fri, Oct 18, 10:15 AM
F13971110: D7988.id.diff
Thu, Oct 17, 11:41 AM
Subscribers

Details

Summary

Some callpaths end up here, which doesn't cause the internal linter's willLintPath() method. This can mean its activePath is set wrong, which results in us raising lint for the wrong file.

Particularly, if you apply D7979 (diff 18069) and arc lint it, you'll get a syntax error message in the wrong file.

Test Plan

Applied D7979 and linted it, got proper error message.

Diff Detail

Branch
willlint
Lint
Lint Passed
Unit
Tests Passed