Page MenuHomePhabricator

Call willLintPath() hook from PhutilLinter
ClosedPublic

Authored by epriestley on Jan 17 2014, 1:50 AM.
Tags
None
Referenced Files
F15454166: D7988.diff
Sat, Mar 29, 4:45 PM
F15437489: D7988.id18112.diff
Tue, Mar 25, 7:47 PM
F15431570: D7988.id.diff
Mon, Mar 24, 1:12 PM
F15431130: D7988.id18070.diff
Mon, Mar 24, 10:42 AM
F15428928: D7988.diff
Sun, Mar 23, 11:26 PM
F15413532: D7988.id18112.diff
Wed, Mar 19, 7:29 PM
F15293650: D7988.id18070.diff
Wed, Mar 5, 4:31 AM
F15293649: D7988.id.diff
Wed, Mar 5, 4:31 AM
Subscribers

Details

Summary

Some callpaths end up here, which doesn't cause the internal linter's willLintPath() method. This can mean its activePath is set wrong, which results in us raising lint for the wrong file.

Particularly, if you apply D7979 (diff 18069) and arc lint it, you'll get a syntax error message in the wrong file.

Test Plan

Applied D7979 and linted it, got proper error message.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped