Page MenuHomePhabricator

Move Git discovery into DiscoveryEngine
ClosedPublic

Authored by epriestley on Jan 17 2014, 1:17 AM.
Tags
None
Referenced Files
F22772618: D7987.id18068.diff
Mon, Oct 5, 8:36 PM
F22730016: D7987.id.diff
Sun, Oct 4, 5:40 AM
F22661684: D7987.diff
Thu, Oct 1, 9:41 AM
F22628016: D7987.id18068.diff
Tue, Sep 29, 10:36 PM
F22608562: D7987.id18088.diff
Tue, Sep 29, 1:23 AM
Unknown Object (File)
Thu, Sep 10, 12:40 PM
Unknown Object (File)
Aug 26 2026, 6:23 PM
Unknown Object (File)
Jun 10 2026, 11:54 PM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

Ref T4327. Consolidates and simplifies infrastructure:

  • Moves Git discovery into DiscoveryEngine.
  • Collapses a bunch of the Git and Mercurial code related to stream discovery.
  • Removes all cach code from PullLocal daemon (it's no longer called).
  • Adds basic unit tests for Git and Mercurial discovery.

Various cleanup:

  • Makes GitStream and MercurialStream extend a common base.
  • Improves performance of MercurialStream in some cases, by requiring fewer commits be output and parsed.
  • Makes mirroring exceptions easier to debug.
  • Fixes discovery of Mercurial repositories with multiple branch heads.
  • Adds some missing pht().
Test Plan

I tested this fairly throughly because I think this phase is complete:

  • Made new repositories in multiple VCSes and did full imports.
    • Particularly, I reimported Arcanist to make sure that TODO was resolved. I think it was related to the toposort stuff.
  • Pushed commits to multiple VCSes.
  • Pushed commits to a non-close branch, then pushed a merge commit. Observed commits import initially as non-close, then get flagged for close.
  • Started full daemons and resolved various minor issues that showed up in the daemon log until everything ran cleanly.
  • Basically spent about 30 minutes banging on this in every way I could think of to try to break it. I found and fixed some minor stuff, but it seems solid.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped