Page MenuHomePhabricator

Move Git discovery into DiscoveryEngine
ClosedPublic

Authored by epriestley on Jan 17 2014, 1:17 AM.
Tags
None
Referenced Files
F14080852: D7987.diff
Fri, Nov 22, 5:08 PM
Unknown Object (File)
Sun, Nov 17, 7:30 PM
Unknown Object (File)
Thu, Nov 14, 5:46 AM
Unknown Object (File)
Sun, Nov 10, 3:30 PM
Unknown Object (File)
Sat, Nov 9, 3:05 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Unknown Object (File)
Wed, Nov 6, 12:36 AM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by btrahan.

Details

Summary

Ref T4327. Consolidates and simplifies infrastructure:

  • Moves Git discovery into DiscoveryEngine.
  • Collapses a bunch of the Git and Mercurial code related to stream discovery.
  • Removes all cach code from PullLocal daemon (it's no longer called).
  • Adds basic unit tests for Git and Mercurial discovery.

Various cleanup:

  • Makes GitStream and MercurialStream extend a common base.
  • Improves performance of MercurialStream in some cases, by requiring fewer commits be output and parsed.
  • Makes mirroring exceptions easier to debug.
  • Fixes discovery of Mercurial repositories with multiple branch heads.
  • Adds some missing pht().
Test Plan

I tested this fairly throughly because I think this phase is complete:

  • Made new repositories in multiple VCSes and did full imports.
    • Particularly, I reimported Arcanist to make sure that TODO was resolved. I think it was related to the toposort stuff.
  • Pushed commits to multiple VCSes.
  • Pushed commits to a non-close branch, then pushed a merge commit. Observed commits import initially as non-close, then get flagged for close.
  • Started full daemons and resolved various minor issues that showed up in the daemon log until everything ran cleanly.
  • Basically spent about 30 minutes banging on this in every way I could think of to try to break it. I found and fixed some minor stuff, but it seems solid.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped