Page MenuHomePhabricator

Legalpad - add a view signatures page
ClosedPublic

Authored by btrahan on Jan 17 2014, 12:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 9:03 PM
Unknown Object (File)
Sun, Dec 15, 3:51 PM
Unknown Object (File)
Sat, Dec 14, 1:06 AM
Unknown Object (File)
Thu, Dec 12, 2:49 PM
Unknown Object (File)
Mon, Dec 9, 3:45 PM
Unknown Object (File)
Sun, Dec 8, 5:26 PM
Unknown Object (File)
Wed, Dec 4, 2:55 PM
Unknown Object (File)
Sat, Nov 30, 3:27 AM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP4e6390774fac: Legalpad - add a view signatures page
Summary

...needs to add a LegalpadDocumentSignatureQuery class to get this done, which is also re-deployed everywhere we were issuing raw queries. Ref T3116.

Test Plan

viewed some signatures. Verified color and footer icons showed up how I wanted them to.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley added inline comments.
src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php
24โ€“36

Will $user (i.e., a logged out user) be able to see the signature? I think they won't, so this will break email signatures?

src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php
24โ€“36

ah, nice catch. i'll just issue a raw query with a comment...

btrahan updated this revision to Unknown Object (????).Jan 17 2014, 7:37 PM

fix not logged in case for verifying sigs