Page MenuHomePhabricator

Remove session limits and sequencing
ClosedPublic

Authored by epriestley on Jan 15 2014, 10:48 PM.

Details

Reviewers
btrahan
Maniphest Tasks
T4310: Allow external users to establish real sessions
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP2ec45d42a689: Remove session limits and sequencing
Summary

Ref T4310. Fixes T3720. This change:

  • Removes concurrent session limits. Instead, unused sessions are GC'd after a while.
  • Collapses all existing "web-1", "web-2", etc., sessions into "web" sessions.
  • Dramatically simplifies the code for establishing a session (like omg).
Test Plan

Ran migration, checked Sessions panel and database for sanity. Used existing session. Logged out, logged in. Ran Conduit commands.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 16 2014, 1:05 AM
btrahan added inline comments.
src/applications/auth/engine/PhabricatorAuthSessionEngine.php
103

nice catch

epriestley closed this revision.Jan 16 2014, 1:29 AM

Closed by commit rP2ec45d42a689 (authored by @epriestley).