Page MenuHomePhabricator

Workboard - Make the edit icons on the columns actually work
ClosedPublic

Authored by mikn on Jan 12 2014, 1:58 AM.

Details

Summary

Made the edit path of the Edit controller work (before only create worked), also added in the link for the cog icon to actually land you on the edit page for the correct column. Some cleanup too. *cough*

Test Plan

Click on gear
Look at fancy title you are about to edit
Change it
Enjoy changed title

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

A couple of minor inlines, this looks good otherwise.

src/applications/project/controller/PhabricatorProjectBoardController.php
46–51

This probably derps for projects with no columns yet, but that's fine.

60

For consistency, include the trailing "/" in this URI. We'll add it automatically if it's omitted, but Phabricator URIs generally end with a "/".

src/applications/project/controller/PhabricatorProjectBoardEditController.php
37–38
  • Use requireCapabilities() to require CAN_EDIT.
  • Add an if (!$column) { return 404; } check.
72–77

This should only be for new columns -- editing a column shouldn't change its sequence number.

Good eye, thank you. :)

src/applications/project/controller/PhabricatorProjectBoardEditController.php
37–38

Thank you!

72–77

Oh, god. I apologise for that. Embarassing!

mikn updated this revision to Unknown Object (????).Jan 12 2014, 2:13 AM
  • Mending some brainfarts.

Cool, thanks! I'll take a shot at the JS shortly.

Closed by commit rP10ea1dd74900 (authored by @mikn, committed by @epriestley).