Page MenuHomePhabricator

Support "Repository's projects" field in Commit and Differential Revision rules
ClosedPublic

Authored by epriestley on Jan 9 2014, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 4:02 AM
Unknown Object (File)
Fri, Dec 20, 11:38 PM
Unknown Object (File)
Tue, Dec 17, 8:57 AM
Unknown Object (File)
Tue, Dec 17, 3:31 AM
Unknown Object (File)
Mon, Dec 16, 4:46 PM
Unknown Object (File)
Sun, Dec 15, 12:14 PM
Unknown Object (File)
Sun, Dec 15, 12:14 PM
Unknown Object (File)
Sun, Dec 15, 12:14 PM
Subscribers
Tokens
"Love" token, awarded by dctrwatson.

Details

Summary

This also cleans up some code a little bit. Most of the gymnastics are to make sure we call needProjectPHIDs() appropriately.

Test Plan

Created new commit and revision rules with this field. Ran commits and revisions through the test console. Field behavior seemed correct.

Diff Detail

Branch
heraldproj
Lint
Lint Passed
Unit
Tests Passed