Page MenuHomePhabricator

Support "Repository's projects" field in Commit and Differential Revision rules
ClosedPublic

Authored by epriestley on Jan 9 2014, 9:43 PM.
Tags
None
Referenced Files
F18783726: D7923.diff
Mon, Oct 13, 9:08 AM
F18768359: D7923.diff
Wed, Oct 8, 3:12 AM
F18752848: D7923.id17932.diff
Sat, Oct 4, 4:35 PM
F18697335: D7923.id.diff
Sat, Sep 27, 9:32 AM
F18531059: D7923.diff
Sep 7 2025, 3:20 AM
F18190122: D7923.id17936.diff
Aug 16 2025, 11:30 PM
F18068085: D7923.id.diff
Aug 4 2025, 3:05 PM
F18042949: D7923.diff
Aug 3 2025, 5:27 AM
Subscribers
Tokens
"Love" token, awarded by dctrwatson.

Details

Summary

This also cleans up some code a little bit. Most of the gymnastics are to make sure we call needProjectPHIDs() appropriately.

Test Plan

Created new commit and revision rules with this field. Ran commits and revisions through the test console. Field behavior seemed correct.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped