Phabricator was going to give me an error message via commit_hook.php, unfortunately said error wasn't being set since
\$callsign was undefined. So, just changed \$callsign to \$argv[1] and now I get the appropriate commit.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPb960c8114b50: Changed \$callsign to \$argv[1] on commit_hook.php since is undefined causing…
- Add commit_hook.php to an SVN pre-commit.
- Set the SVN to be hosted off of Phabricator.
- Attempt to commit to commit to SVN repository.
Expected: Error message saying that the repository isn't hosted on Phabricator
Results: Error message saying undefined function.
Diff Detail
Diff Detail
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Comment Actions
Aw yeah, I now feel productive enough today with something so small.
Now back to replacing JIRA, Confluence, and FishEye with Phabricator at work. Thanks. :D
Comment Actions
(We have lint rules which normally catch this stuff, but they only run on actual library source files (in src/) since they include library-specific stuff. In the long term we should probably do a better job of getting wider coverage, we just have very little code outside of src/ so it has rarely come up.)