Page MenuHomePhabricator

Clean up AphrontError boxes, Diffusion Headers
ClosedPublic

Authored by chad on Jan 9 2014, 4:24 AM.
Tags
None
Referenced Files
F22720713: D7914.id17912.diff
Sat, Oct 3, 9:57 PM
F22588061: D7914.id17912.diff
Mon, Sep 28, 3:15 AM
Unknown Object (File)
Aug 31 2026, 11:27 PM
Unknown Object (File)
Aug 21 2026, 5:04 PM
Unknown Object (File)
Aug 5 2026, 7:04 PM
Unknown Object (File)
Jun 5 2026, 10:55 AM
Unknown Object (File)
Apr 17 2026, 3:35 PM
Unknown Object (File)
Apr 14 2026, 9:30 AM

Details

Summary

Two basic changes here, first we fixed up the Diffusion headers to roll out more PHUIObjectBoxes. Second we added some specific styles for when Errors are inside an ObjectBox at the first position.

Test Plan

Tested a number of different layouts for browsing respositories as well as wherever I could find cases with PHUIObjectBox Form Errors (see images attached). Still some minor tightening due after this diff, but didnt want to overload it.

Diff Detail

Branch
errors
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

{F100141}

{F100142}

{F100143}

{F100144}

{F100145}

Also, I seem to be stuck at importing.. haha.. need to troubleshoot that.