Page MenuHomePhabricator

Clean up AphrontError boxes, Diffusion Headers
ClosedPublic

Authored by chad on Jan 9 2014, 4:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 1:12 AM
Unknown Object (File)
Tue, Mar 12, 1:12 AM
Unknown Object (File)
Tue, Mar 12, 1:12 AM
Unknown Object (File)
Feb 8 2024, 12:02 PM
Unknown Object (File)
Jan 7 2024, 3:57 AM
Unknown Object (File)
Dec 22 2023, 8:05 AM
Unknown Object (File)
Dec 1 2023, 2:18 PM
Unknown Object (File)
Dec 1 2023, 2:18 PM

Details

Summary

Two basic changes here, first we fixed up the Diffusion headers to roll out more PHUIObjectBoxes. Second we added some specific styles for when Errors are inside an ObjectBox at the first position.

Test Plan

Tested a number of different layouts for browsing respositories as well as wherever I could find cases with PHUIObjectBox Form Errors (see images attached). Still some minor tightening due after this diff, but didnt want to overload it.

Diff Detail

Branch
errors
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

{F100141}

{F100142}

{F100143}

{F100144}

{F100145}

Also, I seem to be stuck at importing.. haha.. need to troubleshoot that.