See https://github.com/facebook/arcanist/issues/133. Treat "!" files like "C" and "?" files and make the user deal with them.
Details
Details
>>> orbital ~/repos/INIS $ svn st
! README
>>> orbital ~/repos/INIS $ arc diff
Usage Exception: You have missing files in this working copy. Revert or formally remove them (with `svn rm`) before proceeding.
Working copy: /INSECURE/repos/INIS/
Missing files in working copy:
READMEDiff Detail
Diff Detail
- Branch
- missing
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
| src/workflow/ArcanistBaseWorkflow.php | ||
|---|---|---|
| 829–848 | Particularly, this parallels these existing blocks which handle similar situations. | |
Comment Actions
Also note that arc diff does not automatically execute svn add -- it prompts the user:
$ arc diff You have untracked files in this working copy. Working copy: /INSECURE/repos/INIS/ Untracked files in working copy: newfile Since you don't have 'svn:ignore' rules for these files, you may have forgotten to 'svn add' them. Do you want to add this file to the commit? [y/N]
This is more common and less ambiguous than the incomplete, conflict, or missing cases: we can't reasonably do anything automatic on conflicts, incomplete is extremely rare, and missing should be rare and seems vaguely dangerous to prompt for automatic resolution.