Page MenuHomePhabricator

Point the Phabricator resource map back to webroot/, not webroot/rsrc/
ClosedPublic

Authored by epriestley on Jan 1 2014, 3:19 AM.
Tags
None
Referenced Files
F13200026: D7875.diff
Mon, May 13, 9:20 PM
F13189758: D7875.diff
Sat, May 11, 6:21 AM
Unknown Object (File)
Tue, May 7, 9:51 AM
Unknown Object (File)
Mon, May 6, 6:07 PM
Unknown Object (File)
Fri, May 3, 10:03 AM
Unknown Object (File)
Thu, Apr 25, 3:15 AM
Unknown Object (File)
Apr 12 2024, 12:16 AM
Unknown Object (File)
Apr 11 2024, 10:51 AM
Subscribers

Details

Summary

Ref T4222. Earlier, I adjusted the root from webroot/ to webroot/rsrc/. However, this means that all the /rsrc/x/y/z.jpg fragments in CSS are no longer recognized as resource names.

Since we have like 9,000 things in CSS that do url(/rsrc/xyz.jpg) and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other.

(Both URLs also work fine, but the parsed one will be better once we have real CDN support.)

Test Plan

Verified CSS gets managed resource URIs transformed into it.

Diff Detail

Branch
celerity8
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

src/infrastructure/celerity/CelerityResourceTransformer.php
115–134

This is just allowing /xyz.jpg or xyz.jpg to work.