Page MenuHomePhabricator

Point the Phabricator resource map back to webroot/, not webroot/rsrc/
ClosedPublic

Authored by epriestley on Jan 1 2014, 3:19 AM.
Tags
None
Referenced Files
F15466942: D7875.id17817.diff
Thu, Apr 3, 11:03 AM
F15462247: D7875.id.diff
Tue, Apr 1, 1:18 PM
F15461702: D7875.id.diff
Tue, Apr 1, 10:28 AM
F15457595: D7875.diff
Sun, Mar 30, 5:19 PM
F15396466: D7875.id17814.diff
Sun, Mar 16, 2:30 PM
F15380459: D7875.diff
Fri, Mar 14, 3:09 AM
F15284024: D7875.diff
Mar 4 2025, 9:04 AM
Unknown Object (File)
Feb 28 2025, 6:38 AM
Subscribers

Details

Summary

Ref T4222. Earlier, I adjusted the root from webroot/ to webroot/rsrc/. However, this means that all the /rsrc/x/y/z.jpg fragments in CSS are no longer recognized as resource names.

Since we have like 9,000 things in CSS that do url(/rsrc/xyz.jpg) and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other.

(Both URLs also work fine, but the parsed one will be better once we have real CDN support.)

Test Plan

Verified CSS gets managed resource URIs transformed into it.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/infrastructure/celerity/CelerityResourceTransformer.php
115–135

This is just allowing /xyz.jpg or xyz.jpg to work.