Page MenuHomePhabricator

Point the Phabricator resource map back to webroot/, not webroot/rsrc/
ClosedPublic

Authored by epriestley on Jan 1 2014, 3:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 3:15 AM
Unknown Object (File)
Fri, Apr 12, 12:16 AM
Unknown Object (File)
Thu, Apr 11, 10:51 AM
Unknown Object (File)
Mar 22 2024, 9:21 PM
Unknown Object (File)
Mar 15 2024, 10:36 AM
Unknown Object (File)
Mar 13 2024, 6:44 PM
Unknown Object (File)
Feb 26 2024, 10:40 AM
Unknown Object (File)
Feb 20 2024, 7:24 AM
Subscribers

Details

Summary

Ref T4222. Earlier, I adjusted the root from webroot/ to webroot/rsrc/. However, this means that all the /rsrc/x/y/z.jpg fragments in CSS are no longer recognized as resource names.

Since we have like 9,000 things in CSS that do url(/rsrc/xyz.jpg) and I don't want to fix/test them all, so just make them work as-is. There's no real reason either setting is better than the other.

(Both URLs also work fine, but the parsed one will be better once we have real CDN support.)

Test Plan

Verified CSS gets managed resource URIs transformed into it.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/infrastructure/celerity/CelerityResourceTransformer.php
115–135

This is just allowing /xyz.jpg or xyz.jpg to work.