Page MenuHomePhabricator
Differential D7871

Make resolveResources() and packageResources() private on CelerityResourceMap
ClosedPublic
Actions

Authored by epriestley on Jan 1 2014, 12:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 10, 11:14 AM
Unknown Object (File)
Sat, May 10, 5:15 AM
Unknown Object (File)
Sat, May 10, 1:37 AM
Unknown Object (File)
Thu, May 8, 10:39 AM
Unknown Object (File)
Wed, May 7, 7:23 AM
Unknown Object (File)
Tue, May 6, 8:14 AM
Unknown Object (File)
Apr 23 2025, 10:33 AM
Unknown Object (File)
Apr 12 2025, 9:48 AM
View All Files
Subscribers
aran

Details

Reviewers
hach-que
btrahan
Maniphest Tasks
T4222: Permit Celerity to serve resources in external libphutil modules
Commits
Restricted Diffusion Commit
rP60cb65bfbb2d: Make resolveResources() and packageResources() private on CelerityResourceMap
Summary

Ref T4222. These are the last two "return a big ball of mud" methods. Make the API stronger so I can swap out the implementations.

Test Plan

Reloaded pages.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
skins/
4 lines
infrastructure/
celerity/
75 lines
2 lines
48 lines
2 lines

Diff 17809

View Options

src/applications/phame/skins/PhameBasicTemplateBlogSkin.php

Loading...
View Options

src/infrastructure/celerity/CelerityResourceMap.php

Loading...
View Options

src/infrastructure/celerity/CelerityResourceTransformer.php

Loading...
View Options

src/infrastructure/celerity/CelerityStaticResourceResponse.php

Loading...
View Options

src/infrastructure/celerity/api.php

Loading...
Phabricator · Built by Phacility