Page MenuHomePhabricator

Move the repository policy step into the create workflow
ClosedPublic

Authored by epriestley on Dec 30 2013, 10:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 12:09 PM
Unknown Object (File)
Mon, Dec 16, 12:21 PM
Unknown Object (File)
Sun, Dec 15, 12:11 PM
Unknown Object (File)
Sun, Dec 15, 12:11 PM
Unknown Object (File)
Sun, Dec 15, 10:49 AM
Unknown Object (File)
Sun, Dec 15, 7:53 AM
Unknown Object (File)
Mon, Dec 9, 5:09 PM
Unknown Object (File)
Dec 2 2024, 8:09 PM
Subscribers

Details

Summary

Fixes T4242. It's currently possible to set nonsense defaults and create repositories with unintended policies, because policy configuration isn't part of creation. Instead:

  • put a policy page into the creation workflow;
  • require the selection of valid policies (i.e., prevent creating a repository you can't view / edit).
Test Plan
  • Created imported and hosted repositories, hit policy selection.
  • Edited policies of existing repositories.
  • Tried to set nonsense policies.

Diff Detail

Branch
repo1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

I don't love making setup more complicated, but this step is pretty straightforward.