Page MenuHomePhabricator

Move the repository policy step into the create workflow
ClosedPublic

Authored by epriestley on Dec 30 2013, 10:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 11:49 PM
Unknown Object (File)
Mon, Feb 10, 9:59 PM
Unknown Object (File)
Sun, Feb 9, 11:00 AM
Unknown Object (File)
Sun, Feb 9, 11:00 AM
Unknown Object (File)
Sun, Feb 9, 11:00 AM
Unknown Object (File)
Sun, Feb 9, 11:00 AM
Unknown Object (File)
Jan 28 2025, 9:06 PM
Unknown Object (File)
Jan 28 2025, 7:53 AM
Subscribers

Details

Summary

Fixes T4242. It's currently possible to set nonsense defaults and create repositories with unintended policies, because policy configuration isn't part of creation. Instead:

  • put a policy page into the creation workflow;
  • require the selection of valid policies (i.e., prevent creating a repository you can't view / edit).
Test Plan
  • Created imported and hosted repositories, hit policy selection.
  • Edited policies of existing repositories.
  • Tried to set nonsense policies.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I don't love making setup more complicated, but this step is pretty straightforward.