Page MenuHomePhabricator

Move the repository policy step into the create workflow
ClosedPublic

Authored by epriestley on Dec 30 2013, 10:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:38 AM
Unknown Object (File)
Fri, Apr 12, 8:43 PM
Unknown Object (File)
Thu, Apr 11, 10:33 AM
Unknown Object (File)
Wed, Apr 3, 3:48 PM
Unknown Object (File)
Mar 27 2024, 6:42 PM
Unknown Object (File)
Mar 24 2024, 10:20 PM
Unknown Object (File)
Mar 12 2024, 12:46 AM
Unknown Object (File)
Mar 12 2024, 12:46 AM
Subscribers

Details

Summary

Fixes T4242. It's currently possible to set nonsense defaults and create repositories with unintended policies, because policy configuration isn't part of creation. Instead:

  • put a policy page into the creation workflow;
  • require the selection of valid policies (i.e., prevent creating a repository you can't view / edit).
Test Plan
  • Created imported and hosted repositories, hit policy selection.
  • Edited policies of existing repositories.
  • Tried to set nonsense policies.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I don't love making setup more complicated, but this step is pretty straightforward.