Page MenuHomePhabricator

Move the repository policy step into the create workflow
ClosedPublic

Authored by epriestley on Dec 30 2013, 10:21 PM.
Tags
None
Referenced Files
F15374961: D7856.id17788.diff
Wed, Mar 12, 8:52 PM
F15333318: D7856.id17788.diff
Sat, Mar 8, 1:44 AM
F15332077: D7856.id17770.diff
Fri, Mar 7, 4:29 PM
F15293587: D7856.id17788.diff
Mar 5 2025, 4:28 AM
F15293586: D7856.id.diff
Mar 5 2025, 4:28 AM
F15293585: D7856.diff
Mar 5 2025, 4:28 AM
Unknown Object (File)
Feb 10 2025, 11:49 PM
Unknown Object (File)
Feb 10 2025, 9:59 PM
Subscribers

Details

Summary

Fixes T4242. It's currently possible to set nonsense defaults and create repositories with unintended policies, because policy configuration isn't part of creation. Instead:

  • put a policy page into the creation workflow;
  • require the selection of valid policies (i.e., prevent creating a repository you can't view / edit).
Test Plan
  • Created imported and hosted repositories, hit policy selection.
  • Edited policies of existing repositories.
  • Tried to set nonsense policies.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I don't love making setup more complicated, but this step is pretty straightforward.