Page MenuHomePhabricator

Move the repository policy step into the create workflow
ClosedPublic

Authored by epriestley on Dec 30 2013, 10:21 PM.
Tags
None
Referenced Files
F18889691: D7856.id.diff
Nov 7 2025, 8:52 AM
F18878266: D7856.diff
Nov 6 2025, 4:22 PM
F18765803: D7856.id17788.diff
Oct 7 2025, 1:04 PM
F18765027: D7856.id.diff
Oct 7 2025, 9:09 AM
F18762643: D7856.id17770.diff
Oct 6 2025, 8:02 PM
F18761780: D7856.diff
Oct 6 2025, 4:15 PM
F18629278: D7856.diff
Sep 16 2025, 8:24 AM
F18620460: D7856.diff
Sep 15 2025, 5:18 AM
Subscribers

Details

Summary

Fixes T4242. It's currently possible to set nonsense defaults and create repositories with unintended policies, because policy configuration isn't part of creation. Instead:

  • put a policy page into the creation workflow;
  • require the selection of valid policies (i.e., prevent creating a repository you can't view / edit).
Test Plan
  • Created imported and hosted repositories, hit policy selection.
  • Edited policies of existing repositories.
  • Tried to set nonsense policies.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I don't love making setup more complicated, but this step is pretty straightforward.