Page MenuHomePhabricator

Add "raw author name" and "raw committer name" as Herald fields for commit content hooks
ClosedPublic

Authored by epriestley on Dec 27 2013, 12:04 AM.
Tags
None
Referenced Files
F18888348: D7841.diff
Fri, Nov 7, 7:15 AM
F18871389: D7841.diff
Tue, Nov 4, 10:30 PM
F18869147: D7841.id17735.diff
Tue, Nov 4, 10:05 AM
F18851234: D7841.id.diff
Thu, Oct 30, 11:10 PM
F18846623: D7841.diff
Wed, Oct 29, 8:07 PM
F18816290: D7841.id17751.diff
Tue, Oct 21, 5:49 AM
F18789401: D7841.diff
Wed, Oct 15, 9:32 AM
F18641278: D7841.diff
Sep 18 2025, 8:19 PM
Subscribers

Details

Summary

Ref T4195. A legitimate rule which needs this field is "do not allow commits as root". Interestingly, we have exactly one commit as root in each Phabricator, Arcanist and libphutil.

Since the committer and author don't need to be Phabricator accounts (just the Pusher), the existing "Committer" and "Author" fields can't express this rule (they'll be empty).

Test Plan

{F93406}

Diff Detail

Branch
heraldraw
Lint
Lint Passed
Unit
Tests Passed