Add "raw author name" and "raw committer name" as Herald fields for commit content hooks
ClosedPublic
Actions

Authored by epriestley on Dec 27 2013, 12:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 2:40 AM

	Unknown Object (File)
	Sat, Jan 25, 5:03 PM

	Unknown Object (File)
	Sat, Jan 25, 5:02 PM

	Unknown Object (File)
	Sat, Jan 25, 5:02 PM

	Unknown Object (File)
	Sat, Jan 25, 3:22 AM

	Unknown Object (File)
	Thu, Jan 23, 9:44 PM

	Unknown Object (File)
	Thu, Jan 23, 7:57 AM

	Unknown Object (File)
	Mon, Jan 20, 2:03 AM

View All Files

Subscribers

aran

SEJeff

Details

Reviewers

btrahan

Maniphest Tasks

T4195: Implement pre-commit Herald rules

Commits

Restricted Diffusion Commit
rP9f38aaa5dec4: Add "raw author name" and "raw committer name" as Herald fields for commit…

Summary

Ref T4195. A legitimate rule which needs this field is "do not allow commits as root". Interestingly, we have exactly one commit as root in each Phabricator, Arcanist and libphutil.

Since the committer and author don't need to be Phabricator accounts (just the Pusher), the existing "Committer" and "Author" fields can't express this rule (they'll be empty).

Test Plan

{F93406}