Page MenuHomePhabricator

Add "raw author name" and "raw committer name" as Herald fields for commit content hooks
ClosedPublic

Authored by epriestley on Dec 27 2013, 12:04 AM.
Tags
None
Referenced Files
F13073380: D7841.diff
Mon, Apr 22, 10:38 PM
Unknown Object (File)
Sat, Apr 20, 6:14 PM
Unknown Object (File)
Fri, Apr 12, 12:25 AM
Unknown Object (File)
Thu, Apr 11, 7:31 AM
Unknown Object (File)
Mar 5 2024, 9:17 AM
Unknown Object (File)
Feb 16 2024, 1:58 PM
Unknown Object (File)
Feb 14 2024, 6:54 AM
Unknown Object (File)
Feb 8 2024, 5:12 PM
Subscribers

Details

Summary

Ref T4195. A legitimate rule which needs this field is "do not allow commits as root". Interestingly, we have exactly one commit as root in each Phabricator, Arcanist and libphutil.

Since the committer and author don't need to be Phabricator accounts (just the Pusher), the existing "Committer" and "Author" fields can't express this rule (they'll be empty).

Test Plan

{F93406}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped