Differential D7836

Make Drydock more broadly aware of policies
ClosedPublic
Actions

Authored by epriestley on Dec 26 2013, 9:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 1:22 PM

	Unknown Object (File)
	Sat, Dec 7, 9:26 AM

	Unknown Object (File)
	Nov 30 2024, 6:26 PM

	Unknown Object (File)
	Nov 28 2024, 12:14 AM

	Unknown Object (File)
	Nov 20 2024, 11:44 AM

	Unknown Object (File)
	Nov 19 2024, 1:13 PM

	Unknown Object (File)
	Nov 15 2024, 1:02 PM

	Unknown Object (File)
	Nov 15 2024, 1:02 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T2015: Implement Drydock

Commits

Restricted Diffusion Commit
rP9b0fa5747bf4: Make Drydock more broadly aware of policies

Summary

Ref T2015. Moves a bunch of raw object loads into modern policy-aware queries.

Also straightens out the Log and Lease policies a little bit: there are legitimate states where these objects are not attached to a resource (particularly, while a lease is being acquired). Handle these more gracefully.

Test Plan

Lint / browsed stuff.

Diff Detail

Branch

ddock2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/drydock/blueprint/DrydockBlueprintImplementation.php:125	XHP16	TODO Comment
Advice	src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php:55	XHP16	TODO Comment
Advice	src/applications/drydock/storage/DrydockResource.php:55	XHP16	TODO Comment
Advice	src/applications/drydock/worker/DrydockAllocatorWorker.php:75	XHP16	TODO Comment
Advice	src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php:85	XHP16	TODO Comment

Unit

No Test Coverage

Event Timeline

mfiltered with grace

Closed by commit rP9b0fa5747bf4 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

blueprint/

DrydockBlueprintImplementation.php

15 lines

DrydockWorkingCopyBlueprintImplementation.php

1 line

controller/

DrydockBlueprintCreateController.php

12 lines

DrydockBlueprintViewController.php

9 lines

DrydockLeaseViewController.php

9 lines

DrydockResourceCloseController.php

35 lines

DrydockResourceViewController.php

11 lines

management/

DrydockManagementCloseWorkflow.php

9 lines

DrydockManagementCreateResourceWorkflow.php

17 lines

query/

DrydockLeaseQuery.php

26 lines

DrydockLogQuery.php

56 lines

storage/

DrydockLease.php

12 lines

22 lines

DrydockResource.php

18 lines

worker/

DrydockAllocatorWorker.php

13 lines

harbormaster/

step/

LeaseHostBuildStepImplementation.php

12 lines

storage/

build/

HarbormasterBuildArtifact.php

1 line

Diff 17729

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

Loading...

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

Loading...

src/applications/drydock/controller/DrydockBlueprintCreateController.php

Loading...

src/applications/drydock/controller/DrydockBlueprintViewController.php

Loading...

src/applications/drydock/controller/DrydockLeaseViewController.php

Loading...

src/applications/drydock/controller/DrydockResourceCloseController.php

Loading...

src/applications/drydock/controller/DrydockResourceViewController.php

Loading...

src/applications/drydock/management/DrydockManagementCloseWorkflow.php

Loading...

src/applications/drydock/management/DrydockManagementCreateResourceWorkflow.php

Loading...

src/applications/drydock/query/DrydockLeaseQuery.php

Loading...

src/applications/drydock/query/DrydockLogQuery.php

Loading...

src/applications/drydock/storage/DrydockLease.php

Loading...

src/applications/drydock/storage/DrydockLog.php

Loading...

src/applications/drydock/storage/DrydockResource.php

Loading...

src/applications/drydock/worker/DrydockAllocatorWorker.php

Loading...

src/applications/harbormaster/step/LeaseHostBuildStepImplementation.php

Loading...

src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php

Loading...