Page MenuHomePhabricator
Differential D7826

Make DrydockLease a policy-aware object
ClosedPublic
Actions

Authored by epriestley on Dec 26 2013, 5:17 PM.
Tags
None
Referenced Files
F18777454: D7826.id.diff
Sat, Oct 11, 3:05 AM
F18767916: D7826.id17704.diff
Wed, Oct 8, 12:51 AM
F18729839: D7826.diff
Tue, Sep 30, 11:56 AM
F18703847: D7826.id.diff
Sun, Sep 28, 5:14 AM
F18701789: D7826.diff
Sat, Sep 27, 9:02 PM
F18626953: D7826.id17712.diff
Sep 16 2025, 2:51 AM
F18583159: D7826.id.diff
Sep 11 2025, 9:41 AM
F18252771: D7826.diff
Aug 21 2025, 8:42 PM
View All Files
Subscribers
aran
hach-que

Details

Reviewers
btrahan
Maniphest Tasks
T2015: Implement Drydock
Commits
Restricted Diffusion Commit
rP6b2d480fe793: Make DrydockLease a policy-aware object
Summary

Ref T2015. DrydockLease predates widespread adoption of policies. Make it -- and its query -- policy aware.

Test Plan

Browsed leases from the web UI. Grepped for callsites.

Diff Detail

Branch
ddock1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/drydock/blueprint/DrydockBlueprintImplementation.php:29XHP16TODO Comment
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Unknown Object (????).Dec 26 2013, 5:20 PM
  • Some additional cleanup.
btrahan accepted this revision.Dec 26 2013, 6:29 PM
epriestley closed this revision.Dec 26 2013, 6:41 PM

Closed by commit rP6b2d480fe793 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
blueprint/
3 lines
controller/
2 lines
2 lines
query/
53 lines
storage/
25 lines
harbormaster/
storage/
build/
1 line

Diff 17703

View Options

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

Loading...
View Options

src/applications/drydock/controller/DrydockLeaseListController.php

Loading...
View Options

src/applications/drydock/controller/DrydockResourceViewController.php

Loading...
View Options

src/applications/drydock/query/DrydockLeaseQuery.php

Loading...
View Options

src/applications/drydock/storage/DrydockLease.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php

Loading...
Phabricator · Built by Phacility