Differential D7822

Allow Harbormaster build plans to be disabled
ClosedPublic
Actions

Authored by epriestley on Dec 24 2013, 5:16 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4187: The build plans can't be deleted
T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rP60288edf80cb: Allow Harbormaster build plans to be disabled

Summary

Fixes T4187. Ref T1049. Allows build plans to be enabled or disabled.

Test Plan

Enabled and disabled build plans.

Diff Detail

Branch

disableplan

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/harbormaster/storage/HarbormasterBuildable.php:81	XHP16	TODO Comment

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Dec 26 2013, 6:26 PM

Closed by commit rP60288edf80cb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

harbormaster/

application/

PhabricatorApplicationHarbormaster.php

1 line

controller/

HarbormasterPlanDisableController.php

76 lines

HarbormasterPlanListController.php

4 lines

HarbormasterPlanViewController.php

18 lines

editor/

HarbormasterBuildPlanEditor.php

9 lines

query/

HarbormasterBuildPlanQuery.php

13 lines

HarbormasterBuildPlanSearchEngine.php

33 lines

storage/

HarbormasterBuildable.php

6 lines

configuration/

HarbormasterBuildPlan.php

9 lines

HarbormasterBuildPlanTransaction.php

12 lines

search/

engine/

PhabricatorApplicationSearchEngine.php

45 lines

Diff 17699

View Options

src/__phutil_library_map__.php

View Options

src/applications/harbormaster/application/PhabricatorApplicationHarbormaster.php

View Options

src/applications/harbormaster/controller/HarbormasterPlanDisableController.php

View Options

src/applications/harbormaster/controller/HarbormasterPlanListController.php

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

View Options

src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php

View Options

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php

View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php

View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Allow Harbormaster build plans to be disabledClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17699

src/__phutil_library_map__.php

src/applications/harbormaster/application/PhabricatorApplicationHarbormaster.php

src/applications/harbormaster/controller/HarbormasterPlanDisableController.php

src/applications/harbormaster/controller/HarbormasterPlanListController.php

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php

src/applications/harbormaster/storage/HarbormasterBuildable.php

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlanTransaction.php

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Allow Harbormaster build plans to be disabled
ClosedPublic
Actions

Revision Contents
Changeset List