Page MenuHomePhabricator

Herald - add support for "assignee" conditions
ClosedPublic

Authored by xiaogaozi on Dec 21 2013, 3:01 AM.
Tags
None
Referenced Files
F15484869: D7813.id17689.diff
Wed, Apr 9, 8:40 PM
F15480222: D7813.id17689.diff
Tue, Apr 8, 12:46 PM
F15480121: D7813.id.diff
Tue, Apr 8, 11:56 AM
F15477055: D7813.diff
Apr 7 2025, 11:54 AM
F15408970: D7813.id.diff
Mar 19 2025, 2:26 AM
F15400404: D7813.diff
Mar 17 2025, 11:25 AM
F15354611: D7813.id17689.diff
Mar 11 2025, 5:01 AM
Unknown Object (File)
Feb 25 2025, 3:43 PM
Tokens
"Piece of Eight" token, awarded by Leenug.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP54a0dd813908: Herald - add support for "assignee" conditions
Summary

add support for "assignee" conditions

Test Plan

Create a Herald rule where condition is assignee, and create a task assign to someone.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Thanks! I'm going to make one minor change in the pull (see inline) to make this slightly more flexible.

src/applications/herald/adapter/HeraldAdapter.php
234–235

I think this field should use this set of conditions instead, because a task may not be assigned, so "Assignee does not exist" is a meaningful filter for finding unowned tasks.