Page MenuHomePhabricator
Differential D7812

Minor cleanup for task rendering in Daemons
ClosedPublic
Actions

Authored by epriestley on Dec 20 2013, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 8:43 PM
Unknown Object (File)
Wed, Dec 25, 10:31 PM
Unknown Object (File)
Thu, Dec 12, 2:22 AM
Unknown Object (File)
Sun, Dec 8, 4:24 PM
Unknown Object (File)
Fri, Dec 6, 1:16 PM
Unknown Object (File)
Nov 26 2024, 11:09 PM
Unknown Object (File)
Nov 22 2024, 8:42 PM
Unknown Object (File)
Nov 18 2024, 7:23 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rPc4627135844f: Minor cleanup for task rendering in Daemons
Summary

Fixes two issues:

  • When rendering a task's details, we currently issue a policy-oblivious query. Instead, issue a policy-aware query.
  • The formatting is a little bit weird, with the top half in a box and the bottom half with an older style. Make them consistent.
Test Plan

Looked at the detail pages for several tasks in queue.

Diff Detail

Branch
daemon1
Lint
Lint Passed
Unit
Tests Passed

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
controller/
18 lines
metamta/
2 lines
repository/
worker/
20 lines
infrastructure/
daemon/
workers/
2 lines

Diff 17678

View Options

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

Loading...
View Options

src/applications/metamta/PhabricatorMetaMTAWorker.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

Loading...
View Options

src/infrastructure/daemon/workers/PhabricatorWorker.php

Loading...
Phabricator · Built by Phacility