Page MenuHomePhabricator
Differential D7809

Add "is merge commit" Herald field for pre-commit rules
ClosedPublic
Actions

Authored by epriestley on Dec 20 2013, 12:23 AM.
Tags
None
Referenced Files
F14066495: D7809.diff
Tue, Nov 19, 10:05 AM
F14013072: D7809.id17674.diff
Sat, Nov 2, 12:23 AM
F14011944: D7809.id17666.diff
Fri, Nov 1, 6:13 AM
F14011943: D7809.id.diff
Fri, Nov 1, 6:12 AM
F14011833: D7809.diff
Fri, Nov 1, 5:26 AM
F13986719: D7809.id17666.diff
Oct 21 2024, 5:03 AM
Unknown Object (File)
Sep 6 2024, 9:46 AM
Unknown Object (File)
Aug 30 2024, 7:03 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rPa64d127e2569: Add "is merge commit" Herald field for pre-commit rules
Summary

Ref T4195. This allows you to write rules which disallow merge commits.

Also make the reject message a little more useful.

Test Plan
remote: This push was rejected by Herald push rule H27.
remote: Change: commit/daed0d448404
remote:   Rule: No Merges
remote: Reason: No merge commits allowed. If you must push a merge, include "@force-merge" in the commit message.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
13 lines
herald/
23 lines
herald/
adapter/
17 lines

Diff 17674

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
Phabricator · Built by Phacility