Page MenuHomePhabricator
Differential D7809

Add "is merge commit" Herald field for pre-commit rules
ClosedPublic
Actions

Authored by epriestley on Dec 20 2013, 12:23 AM.
Tags
None
Referenced Files
F15479848: D7809.id.diff
Tue, Apr 8, 9:46 AM
F15476028: D7809.diff
Mon, Apr 7, 2:36 AM
F15414983: D7809.id17666.diff
Thu, Mar 20, 3:23 AM
F15409305: D7809.id17674.diff
Wed, Mar 19, 4:05 AM
F15389067: D7809.id.diff
Sat, Mar 15, 4:51 AM
F15371151: D7809.diff
Wed, Mar 12, 11:16 AM
Unknown Object (File)
Mar 3 2025, 10:54 PM
Unknown Object (File)
Feb 9 2025, 10:55 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rPa64d127e2569: Add "is merge commit" Herald field for pre-commit rules
Summary

Ref T4195. This allows you to write rules which disallow merge commits.

Also make the reject message a little more useful.

Test Plan
remote: This push was rejected by Herald push rule H27.
remote: Change: commit/daed0d448404
remote:   Rule: No Merges
remote: Reason: No merge commits allowed. If you must push a merge, include "@force-merge" in the commit message.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
13 lines
herald/
23 lines
herald/
adapter/
17 lines

Diff 17674

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
Phabricator · Built by Phacility