Differential D7808

Modernize Diffusion `commitparentsquery`
ClosedPublic
Actions

Authored by epriestley on Dec 20 2013, 12:04 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T4195: Implement pre-commit Herald rules
T2783: Make working-copy operations service-oriented

Commits

Restricted Diffusion Commit
rP9c938701c3dd: Modernize Diffusion `commitparentsquery`

Summary

Ref T4195. Ref T2783. We have an old-school implementation of this; move it into a LowLevel query and make callers all run through Conduit. I need the LowLevel query for hooks, to implement an "is merge commit" Herald rule.

Test Plan

Ran query via Conduit for SVN, Mercurial, Git.
Parsed a commit which closed a revision, attach/closed worked correctly.
Browsed Diffusion.

Diff Detail

Branch

hashq5

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Dec 20 2013, 2:13 AM

Closed by commit rP9c938701c3dd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

10 lines

applications/

diffusion/

conduit/

ConduitAPI_diffusion_commitparentsquery_Method.php

16 lines

controller/

DiffusionBrowseFileController.php

14 lines

DiffusionCommitController.php

8 lines

query/

lowlevel/

DiffusionLowLevelParentsQuery.php

84 lines

parents/

DiffusionCommitParentsQuery.php

DiffusionGitCommitParentsQuery.php

DiffusionMercurialCommitParentsQuery.php

DiffusionSvnCommitParentsQuery.php

harbormaster/

step/

WaitForPreviousBuildStepImplementation.php

7 lines

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

26 lines

Diff 17665

View Options

src/__phutil_library_map__.php

View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_commitparentsquery_Method.php

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php

View Options

src/applications/diffusion/query/parents/DiffusionCommitParentsQuery.php

View Options

src/applications/diffusion/query/parents/DiffusionGitCommitParentsQuery.php

View Options

src/applications/diffusion/query/parents/DiffusionMercurialCommitParentsQuery.php

View Options

src/applications/diffusion/query/parents/DiffusionSvnCommitParentsQuery.php

View Options

src/applications/harbormaster/step/WaitForPreviousBuildStepImplementation.php

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Modernize Diffusion `commitparentsquery`ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17665

src/__phutil_library_map__.php

src/applications/diffusion/conduit/ConduitAPI_diffusion_commitparentsquery_Method.php

src/applications/diffusion/controller/DiffusionBrowseFileController.php

src/applications/diffusion/controller/DiffusionCommitController.php

src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php

src/applications/diffusion/query/parents/DiffusionCommitParentsQuery.php

src/applications/diffusion/query/parents/DiffusionGitCommitParentsQuery.php

src/applications/diffusion/query/parents/DiffusionMercurialCommitParentsQuery.php

src/applications/diffusion/query/parents/DiffusionSvnCommitParentsQuery.php

src/applications/harbormaster/step/WaitForPreviousBuildStepImplementation.php

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Modernize Diffusion `commitparentsquery`
ClosedPublic
Actions

Revision Contents
Changeset List