Paths

Table of Contentst

Move mercurial commit metadata parsing into a LowLevel query
ClosedPublic
Actions

Authored by epriestley on Dec 18 2013, 11:00 PM.

Tags

None

Referenced Files

	F14019805: D7795.diff
	Tue, Nov 5, 11:40 PM

	F14016199: D7795.diff
	Mon, Nov 4, 7:07 AM

	F14015025: D7795.id17646.diff
	Sun, Nov 3, 12:20 PM

	F14014012: D7795.id.diff
	Sat, Nov 2, 8:46 PM

	F13982717: D7795.id17634.diff
	Sun, Oct 20, 1:23 AM

	F13978768: D7795.diff
	Sat, Oct 19, 12:53 AM

	F13965830: D7795.id.diff
	Wed, Oct 16, 4:30 AM

	F13959799: D7795.id17646.diff
	Mon, Oct 14, 8:47 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4195: Implement pre-commit Herald rules

Commits

Restricted Diffusion Commit
rP92bc76aae053: Move mercurial commit metadata parsing into a LowLevel query

Summary

Ref T4195. Same as D7793, but for mercurial. (As usual, SVN needs some goofy nonsense instead, so the next diff will just make this field work.)

Test Plan

Ran reparse.php on Git and Mercurial commits, var_dump'd the output and it looked correct.

Diff Detail

Branch

hbody2

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Dec 19 2013, 12:16 AM

Closed by commit rP92bc76aae053 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

diffusion/

data/

DiffusionCommitRef.php

20 lines

query/

lowlevel/

DiffusionLowLevelMercurialCommitQuery.php

41 lines

repository/

worker/

commitmessageparser/

PhabricatorRepositoryGitCommitMessageParserWorker.php

20 lines

PhabricatorRepositoryMercurialCommitMessageParserWorker.php

15 lines

Diff 17634

View Options

src/__phutil_library_map__.php

View Options

src/applications/diffusion/data/DiffusionCommitRef.php

View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelMercurialCommitQuery.php

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php

Move mercurial commit metadata parsing into a LowLevel queryClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17634

src/__phutil_library_map__.php

src/applications/diffusion/data/DiffusionCommitRef.php

src/applications/diffusion/query/lowlevel/DiffusionLowLevelMercurialCommitQuery.php

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php

Move mercurial commit metadata parsing into a LowLevel query
ClosedPublic
Actions

Revision Contents
Changeset List