Page MenuHomePhabricator
Differential D7787

Provide convenience method addTextCrumb() to PhabricatorCrumbsView
ClosedPublic
Actions

Authored by epriestley on Dec 18 2013, 7:34 PM.
Tags
None
Referenced Files
F14833109: D7787.id17617.largetrue.diff
Thu, Jan 30, 8:33 AM
Unknown Object (File)
Tue, Jan 28, 6:08 AM
Unknown Object (File)
Mon, Jan 27, 10:42 AM
Unknown Object (File)
Wed, Jan 22, 3:18 AM
Unknown Object (File)
Tue, Jan 21, 9:06 AM
Unknown Object (File)
Fri, Jan 17, 6:14 PM
Unknown Object (File)
Wed, Jan 15, 8:12 PM
Unknown Object (File)
Fri, Jan 10, 12:56 AM
View All Files
Subscribers
aran
hach-que

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rPa5dc9067af0c: Provide convenience method addTextCrumb() to PhabricatorCrumbsView
Summary

We currently have a lot of calls to addCrumb(id(new PhabricatorCrumbView())->...) which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan
  • This was mostly automated, then I cleaned up a few unusual sites manually.
  • Bunch of grep / randomly clicking around.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Large Diff

This large diff affects 154 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
controller/
9 lines
9 lines
14 lines
12 lines
4 lines
4 lines
4 lines
config/
4 lines
4 lines
4 lines
chatlog/
controller/
5 lines
5 lines
conduit/
controller/
12 lines
4 lines
4 lines
4 lines
config/
controller/
4 lines
15 lines
10 lines
5 lines
10 lines
5 lines
countdown/
controller/
13 lines
4 lines
daemon/
controller/
4 lines
13 lines
4 lines
4 lines
4 lines
differential/
controller/
4 lines
4 lines
18 lines
5 lines
diffusion/
controller/
4 lines
4 lines
4 lines
4 lines
4 lines
14 lines
4 lines
8 lines
4 lines
4 lines
4 lines
4 lines
diviner/
controller/
11 lines
7 lines
4 lines
drydock/
controller/
8 lines
5 lines
4 lines
5 lines
5 lines
5 lines
5 lines
4 lines
feed/
controller/
4 lines
files/
controller/
7 lines
5 lines
harbormaster/
controller/
4 lines
13 lines
4 lines
7 lines
15 lines
4 lines
11 lines
herald/
controller/
4 lines
4 lines
7 lines
4 lines
11 lines
11 lines
4 lines
legalpad/
controller/
3 lines
7 lines
macro/
controller/
11 lines
10 lines
7 lines
mailinglists/
controller/
8 lines
maniphest/
controller/
4 lines
4 lines
7 lines
9 lines
meta/
controller/
4 lines
9 lines
nuance/
controller/
4 lines
owners/
controller/
4 lines
passphrase/
controller/
4 lines
15 lines
4 lines
paste/
controller/
8 lines
5 lines
people/
controller/
15 lines
7 lines
5 lines
4 lines
9 lines
9 lines
phame/
controller/
blog/
5 lines
5 lines
5 lines
post/
7 lines
5 lines
5 lines
5 lines
7 lines
phlux/
controller/
10 lines
5 lines
5 lines
pholio/
controller/
10 lines
5 lines
5 lines
phortune/
controller/
5 lines
10 lines
14 lines
5 lines
14 lines
phragment/
controller/
12 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
phriction/
controller/
13 lines
15 lines
8 lines
ponder/
controller/
9 lines
14 lines
13 lines
9 lines
5 lines
project/
controller/
7 lines
13 lines
14 lines
4 lines
14 lines
9 lines
releeph/
controller/
10 lines
branch/
4 lines
4 lines
4 lines
project/
4 lines
4 lines
request/
13 lines
19 lines
search/
controller/
9 lines
4 lines
4 lines
slowvote/
controller/
4 lines
4 lines
tokens/
controller/
4 lines
4 lines
view/
layout/
16 lines

Diff 17644

View Options

src/applications/auth/controller/PhabricatorAuthConfirmLinkController.php

View Options

src/applications/auth/controller/PhabricatorAuthLinkController.php

View Options

src/applications/auth/controller/PhabricatorAuthLoginController.php

View Options

src/applications/auth/controller/PhabricatorAuthRegisterController.php

View Options

src/applications/auth/controller/PhabricatorAuthStartController.php

View Options

src/applications/auth/controller/PhabricatorEmailLoginController.php

View Options

src/applications/auth/controller/PhabricatorEmailVerificationController.php

View Options

src/applications/auth/controller/config/PhabricatorAuthEditController.php

View Options

src/applications/auth/controller/config/PhabricatorAuthListController.php

View Options

src/applications/auth/controller/config/PhabricatorAuthNewController.php

View Options

src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php

View Options

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

View Options

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

View Options

src/applications/conduit/controller/PhabricatorConduitLogController.php

View Options

src/applications/conduit/controller/PhabricatorConduitTokenController.php

View Options

src/applications/config/controller/PhabricatorConfigAllController.php

View Options

src/applications/config/controller/PhabricatorConfigEditController.php

View Options

src/applications/config/controller/PhabricatorConfigGroupController.php

View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

View Options

src/applications/config/controller/PhabricatorConfigIssueViewController.php

View Options

src/applications/config/controller/PhabricatorConfigListController.php

View Options

src/applications/countdown/controller/PhabricatorCountdownEditController.php

View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

View Options

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

View Options

src/applications/daemon/controller/PhabricatorDaemonLogEventViewController.php

View Options

src/applications/daemon/controller/PhabricatorDaemonLogListController.php

View Options

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

View Options

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

View Options

src/applications/differential/controller/DifferentialDiffCreateController.php

View Options

src/applications/differential/controller/DifferentialDiffViewController.php

View Options

src/applications/differential/controller/DifferentialRevisionEditController.php

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

View Options

src/applications/diffusion/controller/DiffusionLintController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditLocalController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php

View Options

src/applications/diffusion/controller/DiffusionRepositoryNewController.php

View Options

src/applications/diviner/controller/DivinerAtomController.php

View Options

src/applications/diviner/controller/DivinerBookController.php

View Options

src/applications/diviner/controller/DivinerLegacyController.php

View Options

src/applications/drydock/controller/DrydockBlueprintEditController.php

View Options

src/applications/drydock/controller/DrydockBlueprintListController.php

View Options

src/applications/drydock/controller/DrydockBlueprintViewController.php

View Options

src/applications/drydock/controller/DrydockLeaseListController.php

View Options

src/applications/drydock/controller/DrydockLeaseViewController.php

View Options

src/applications/drydock/controller/DrydockLogController.php

View Options

src/applications/drydock/controller/DrydockResourceListController.php

View Options

src/applications/drydock/controller/DrydockResourceViewController.php

View Options

src/applications/feed/controller/PhabricatorFeedDetailController.php

View Options

src/applications/files/controller/PhabricatorFileInfoController.php

View Options

src/applications/files/controller/PhabricatorFileUploadController.php

View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

View Options

src/applications/harbormaster/controller/HarbormasterBuildableEditController.php

View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

View Options

src/applications/harbormaster/controller/HarbormasterPlanController.php

View Options

src/applications/harbormaster/controller/HarbormasterPlanEditController.php

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

View Options

src/applications/harbormaster/controller/HarbormasterStepEditController.php

View Options

src/applications/herald/controller/HeraldNewController.php

View Options

src/applications/herald/controller/HeraldRuleController.php

View Options

src/applications/herald/controller/HeraldRuleEditHistoryController.php

View Options

src/applications/herald/controller/HeraldRuleViewController.php

View Options

src/applications/herald/controller/HeraldTestConsoleController.php

View Options

src/applications/herald/controller/HeraldTranscriptController.php

View Options

src/applications/herald/controller/HeraldTranscriptListController.php

View Options

src/applications/legalpad/controller/LegalpadDocumentEditController.php

View Options

src/applications/legalpad/controller/LegalpadDocumentViewController.php

View Options

src/applications/macro/controller/PhabricatorMacroAudioController.php

View Options

src/applications/macro/controller/PhabricatorMacroEditController.php

View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

View Options

src/applications/mailinglists/controller/PhabricatorMailingListsEditController.php

View Options

src/applications/maniphest/controller/ManiphestBatchEditController.php

View Options

src/applications/maniphest/controller/ManiphestReportController.php

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

View Options

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

View Options

src/applications/meta/controller/PhabricatorApplicationEditController.php

View Options

src/applications/nuance/controller/NuanceSourceViewController.php

View Options

src/applications/owners/controller/PhabricatorOwnersController.php

View Options

src/applications/passphrase/controller/PassphraseCredentialCreateController.php

View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php

View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

View Options

src/applications/paste/controller/PhabricatorPasteEditController.php

View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

View Options

src/applications/people/controller/PhabricatorPeopleEditController.php

View Options

src/applications/people/controller/PhabricatorPeopleLdapController.php

View Options

src/applications/people/controller/PhabricatorPeopleLogsController.php

View Options

src/applications/people/controller/PhabricatorPeopleProfileController.php

View Options

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

View Options

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

View Options

src/applications/phame/controller/blog/PhameBlogEditController.php

View Options

src/applications/phame/controller/blog/PhameBlogListController.php

View Options

src/applications/phame/controller/blog/PhameBlogViewController.php

View Options

src/applications/phame/controller/post/PhamePostEditController.php

View Options

src/applications/phame/controller/post/PhamePostListController.php

View Options

src/applications/phame/controller/post/PhamePostNewController.php

View Options

src/applications/phame/controller/post/PhamePostPublishController.php

View Options

src/applications/phame/controller/post/PhamePostViewController.php

View Options

src/applications/phlux/controller/PhluxEditController.php

View Options

src/applications/phlux/controller/PhluxListController.php

View Options

src/applications/phlux/controller/PhluxViewController.php

View Options

src/applications/pholio/controller/PholioImageHistoryController.php

View Options

src/applications/pholio/controller/PholioMockEditController.php

View Options

src/applications/pholio/controller/PholioMockViewController.php

View Options

src/applications/phortune/controller/PhortuneAccountViewController.php

View Options

src/applications/phortune/controller/PhortunePaymentMethodEditController.php

View Options

src/applications/phortune/controller/PhortuneProductEditController.php

View Options

src/applications/phortune/controller/PhortuneProductListController.php

View Options

src/applications/phortune/controller/PhortuneProductViewController.php

View Options

src/applications/phragment/controller/PhragmentController.php

View Options

src/applications/phragment/controller/PhragmentCreateController.php

View Options

src/applications/phragment/controller/PhragmentPolicyController.php

View Options

src/applications/phragment/controller/PhragmentSnapshotCreateController.php

View Options

src/applications/phragment/controller/PhragmentSnapshotViewController.php

View Options

src/applications/phragment/controller/PhragmentUpdateController.php

View Options

src/applications/phragment/controller/PhragmentVersionController.php

View Options

src/applications/phriction/controller/PhrictionDiffController.php

View Options

src/applications/phriction/controller/PhrictionEditController.php

View Options

src/applications/phriction/controller/PhrictionHistoryController.php

View Options

src/applications/ponder/controller/PonderAnswerEditController.php

View Options

src/applications/ponder/controller/PonderAnswerHistoryController.php

View Options

src/applications/ponder/controller/PonderQuestionEditController.php

View Options

src/applications/ponder/controller/PonderQuestionHistoryController.php

View Options

src/applications/ponder/controller/PonderQuestionViewController.php

View Options

src/applications/project/controller/PhabricatorProjectCreateController.php

View Options

src/applications/project/controller/PhabricatorProjectHistoryController.php

View Options

src/applications/project/controller/PhabricatorProjectMembersEditController.php

View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

View Options

src/applications/project/controller/PhabricatorProjectProfileEditController.php

View Options

src/applications/project/controller/PhabricatorProjectProfilePictureController.php

View Options

src/applications/releeph/controller/ReleephProjectController.php

View Options

src/applications/releeph/controller/branch/ReleephBranchCreateController.php

View Options

src/applications/releeph/controller/branch/ReleephBranchEditController.php

View Options

src/applications/releeph/controller/branch/ReleephBranchHistoryController.php

View Options

src/applications/releeph/controller/project/ReleephProjectCreateController.php

View Options

src/applications/releeph/controller/project/ReleephProjectHistoryController.php

View Options

src/applications/releeph/controller/request/ReleephRequestEditController.php

View Options

src/applications/releeph/controller/request/ReleephRequestViewController.php

View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

View Options

src/applications/search/controller/PhabricatorSearchController.php

View Options

src/applications/search/controller/PhabricatorSearchEditController.php

View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

View Options

src/applications/tokens/controller/PhabricatorTokenGivenController.php

View Options

src/applications/tokens/controller/PhabricatorTokenLeaderController.php

View Options

src/view/layout/PhabricatorCrumbsView.php

Phabricator · Built by Phacility