Page MenuHomePhabricator

Provide convenience method addTextCrumb() to PhabricatorCrumbsView
ClosedPublic

Authored by epriestley on Dec 18 2013, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 17, 8:56 PM
Unknown Object (File)
Sun, Mar 10, 1:17 PM
Unknown Object (File)
Jan 28 2024, 3:01 AM
Unknown Object (File)
Jan 20 2024, 12:29 AM
Unknown Object (File)
Jan 20 2024, 12:29 AM
Unknown Object (File)
Jan 20 2024, 12:29 AM
Unknown Object (File)
Jan 19 2024, 11:15 PM
Unknown Object (File)
Dec 23 2023, 12:35 PM
Subscribers

Details

Summary

We currently have a lot of calls to addCrumb(id(new PhabricatorCrumbView())->...) which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan
  • This was mostly automated, then I cleaned up a few unusual sites manually.
  • Bunch of grep / randomly clicking around.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped