Page MenuHomePhabricator

Provide convenience method addTextCrumb() to PhabricatorCrumbsView
ClosedPublic

Authored by epriestley on Dec 18 2013, 7:34 PM.
Tags
None
Referenced Files
F15466983: D7787.id17644.diff
Thu, Apr 3, 11:30 AM
F15443777: D7787.id17644.largetrue.diff
Thu, Mar 27, 6:07 AM
F15418957: D7787.id17644.diff
Fri, Mar 21, 2:43 AM
F15417805: D7787.id17644.largetrue.diff
Thu, Mar 20, 6:43 PM
F15416660: D7787.id17644.largetrue.diff
Thu, Mar 20, 12:50 PM
F15414404: D7787.id17644.diff
Thu, Mar 20, 12:29 AM
F15397235: D7787.largetrue.diff
Sun, Mar 16, 7:04 PM
F15396598: D7787.id.largetrue.diff
Sun, Mar 16, 3:18 PM
Subscribers

Details

Summary

We currently have a lot of calls to addCrumb(id(new PhabricatorCrumbView())->...) which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan
  • This was mostly automated, then I cleaned up a few unusual sites manually.
  • Bunch of grep / randomly clicking around.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped