Allow Herald rules to be referred to with H123, etc., like other object types are. Herald rules now have proper PHIDs and an increasingly prominent role in triggering application actions. Although I suspect users will rarely use H123 in Remarkup to mention rules, this can simplify some of the interfaces which relate objects across systems.
Details
Details
- Reviewers
btrahan - Commits
- Restricted Diffusion Commit
rP1ff3ef382d84: Give Herald rules a standard "Hnnn" object name
Looked at various interfaces and saw H123 names. Mentioned H123 in remarkup.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I think this is a great change because even though I agree it will be rarely used it will be crazy helpful when used, especially where we can add it in like you did with the commit worker.
| src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php | ||
|---|---|---|
| 235–241 | v. nice | |
| src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php | ||
|---|---|---|
| 235–241 | Yeah, this kind of thing is the big value in doing this to me too. | |