Fix an issue in Harbormaster when a buildable has no repository
ClosedPublic
Actions

Authored by epriestley on Dec 14 2013, 1:31 AM.

Tags

None

Referenced Files

	F13105220: D7771.diff
	Sat, Apr 27, 2:33 PM

	Unknown Object (File)
	Thu, Apr 25, 2:16 AM

	Unknown Object (File)
	Mon, Apr 22, 6:07 AM

	Unknown Object (File)
	Fri, Apr 19, 3:30 AM

	Unknown Object (File)
	Fri, Apr 19, 3:30 AM

	Unknown Object (File)
	Fri, Apr 19, 3:30 AM

	Unknown Object (File)
	Thu, Apr 11, 4:41 AM

	Unknown Object (File)
	Sat, Apr 6, 11:14 PM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
zeeg
btrahan

Maniphest Tasks

T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rP0011068d7a69: Fix an issue in Harbormaster when a buildable has no repository

Summary

Not every revision belongs to a repository, so we might end up here with $repo still equal to null. Don't fatal if we do.

Test Plan

iiam

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que accepted this revision.Dec 14 2013, 1:52 AM

Closed by commit rP0011068d7a69 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuild.php

9 lines

Diff 17574

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Fix an issue in Harbormaster when a buildable has no repositoryClosedPublicActions