Fix an issue in Harbormaster when a buildable has no repository
ClosedPublic
Actions

Authored by epriestley on Dec 14 2013, 1:31 AM.

Tags

None

Referenced Files

	F15554001: D7771.id17574.diff
	Mon, Apr 28, 4:54 AM

	F15548889: D7771.id.diff
	Sun, Apr 27, 2:43 AM

	F15547962: D7771.diff
	Sat, Apr 26, 8:56 PM

	F15507165: D7771.diff
	Tue, Apr 15, 4:57 PM

	F15466265: D7771.id17574.diff
	Apr 3 2025, 3:36 AM

	F15431951: D7771.id17574.diff
	Mar 24 2025, 3:28 PM

	F15406784: D7771.id17573.diff
	Mar 18 2025, 1:52 PM

	F15404072: D7771.id17573.diff
	Mar 18 2025, 6:05 AM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
zeeg
btrahan

Maniphest Tasks

T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rP0011068d7a69: Fix an issue in Harbormaster when a buildable has no repository

Summary

Not every revision belongs to a repository, so we might end up here with $repo still equal to null. Don't fatal if we do.

Test Plan

iiam

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que accepted this revision.Dec 14 2013, 1:52 AM

Closed by commit rP0011068d7a69 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuild.php

9 lines

Diff 17574

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Fix an issue in Harbormaster when a buildable has no repositoryClosedPublicActions