Support bookmark hook operations in Mercurial
ClosedPublic
Actions

Authored by epriestley on Dec 13 2013, 12:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 9:13 PM

	Unknown Object (File)
	Sat, Nov 23, 9:28 AM

	Unknown Object (File)
	Thu, Nov 21, 10:24 AM

	Unknown Object (File)
	Sun, Nov 17, 12:17 AM

	Unknown Object (File)
	Mon, Nov 11, 2:36 AM

	Unknown Object (File)
	Fri, Nov 1, 12:32 AM

	Unknown Object (File)
	Oct 25 2024, 6:29 PM

	Unknown Object (File)
	Oct 25 2024, 6:29 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4195: Implement pre-commit Herald rules

Commits

Restricted Diffusion Commit
rP74251b363675: Support bookmark hook operations in Mercurial

Summary

Ref T4195. Turns bookmark mutations in Mercurial into log objects.

Test Plan

Pushed a pile of bookmarks and got logs:

{F89313}

Diff Detail

Branch

morehooks3

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/diffusion/engine/DiffusionCommitHookEngine.php:699	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Dec 13 2013, 6:30 PM

btrahan added inline comments.

src/applications/repository/storage/PhabricatorRepositoryPushLog.php
21	just double checking this won't cause any issues with legacy data?

Yeah, I added it earlier in this chain and haven't actually committed it yet.

Closed by commit rP74251b363675 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

repository/

commit_hook.php

7 lines

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

115 lines

repository/

engine/

PhabricatorRepositoryPullEngine.php

16 lines

storage/

PhabricatorRepositoryPushLog.php

1 line

Diff 17561

View Options

scripts/repository/commit_hook.php

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

View Options

src/applications/repository/storage/PhabricatorRepositoryPushLog.php

Support bookmark hook operations in MercurialClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17561

scripts/repository/commit_hook.php

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

src/applications/repository/storage/PhabricatorRepositoryPushLog.php

Support bookmark hook operations in Mercurial
ClosedPublic
Actions

Revision Contents
Changeset List