Page MenuHomePhabricator

Support bookmark hook operations in Mercurial
ClosedPublic

Authored by epriestley on Dec 13 2013, 12:59 AM.
Tags
None
Referenced Files
F18747390: D7764.diff
Fri, Oct 3, 3:57 PM
F18599884: D7764.diff
Sat, Sep 13, 8:30 AM
F18589812: D7764.diff
Fri, Sep 12, 4:21 AM
F18055821: D7764.id17599.diff
Aug 4 2025, 7:54 AM
F18049410: D7764.id.diff
Aug 3 2025, 4:10 PM
F18004403: D7764.diff
Aug 2 2025, 12:10 PM
Unknown Object (File)
Jul 1 2025, 6:37 PM
Unknown Object (File)
Apr 19 2025, 11:10 PM
Subscribers

Details

Summary

Ref T4195. Turns bookmark mutations in Mercurial into log objects.

Test Plan

Pushed a pile of bookmarks and got logs:

{F89313}

Diff Detail

Branch
morehooks3
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/engine/DiffusionCommitHookEngine.php:699XHP16TODO Comment
Unit
Tests Passed

Event Timeline

btrahan added inline comments.
src/applications/repository/storage/PhabricatorRepositoryPushLog.php
21

just double checking this won't cause any issues with legacy data?

Yeah, I added it earlier in this chain and haven't actually committed it yet.