Page MenuHomePhabricator
Differential D7764

Support bookmark hook operations in Mercurial
ClosedPublic
Actions

Authored by epriestley on Dec 13 2013, 12:59 AM.
Tags
None
Referenced Files
F14442707: D7764.diff
Thu, Dec 26, 8:46 AM
Unknown Object (File)
Mon, Dec 23, 11:02 PM
Unknown Object (File)
Sun, Dec 8, 8:24 PM
Unknown Object (File)
Wed, Dec 4, 5:32 PM
Unknown Object (File)
Tue, Dec 3, 7:28 AM
Unknown Object (File)
Mon, Dec 2, 9:18 PM
Unknown Object (File)
Fri, Nov 29, 11:59 AM
Unknown Object (File)
Thu, Nov 28, 11:59 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rP74251b363675: Support bookmark hook operations in Mercurial
Summary

Ref T4195. Turns bookmark mutations in Mercurial into log objects.

Test Plan

Pushed a pile of bookmarks and got logs:

{F89313}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 13 2013, 6:30 PM
btrahan added inline comments.
src/applications/repository/storage/PhabricatorRepositoryPushLog.php
21

just double checking this won't cause any issues with legacy data?

epriestley added a comment.Dec 13 2013, 6:39 PM

Yeah, I added it earlier in this chain and haven't actually committed it yet.

epriestley closed this revision.Dec 17 2013, 4:34 PM

Closed by commit rP74251b363675 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
scripts/
repository/
7 lines
src/
applications/
diffusion/
engine/
115 lines
repository/
engine/
16 lines
storage/
1 line

Diff 17599

View Options

scripts/repository/commit_hook.php

Loading...
View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryPushLog.php

Loading...
Phabricator · Built by Phacility