Paths

Table of Contentst

Differential D7759

Fix some repository URI handling issues in Git and Mercurial
ClosedPublic
Actions

Authored by epriestley on Dec 12 2013, 12:30 AM.

Tags

None

Referenced Files

	F13217926: D7759.id17552.diff
	Sat, May 18, 9:04 AM

	F13217925: D7759.id17553.diff
	Sat, May 18, 9:04 AM

	F13217924: D7759.id17550.diff
	Sat, May 18, 9:04 AM

	F13217764: D7759.diff
	Sat, May 18, 7:57 AM

	F13212532: D7759.diff
	Fri, May 17, 6:50 AM

	F13195973: D7759.diff
	Sun, May 12, 10:48 PM

	F13179849: D7759.diff
	Wed, May 8, 9:29 PM

	Unknown Object (File)
	Sat, May 4, 8:40 PM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rPd846f6508b2c: Fix some repository URI handling issues in Git and Mercurial

Summary

See https://github.com/facebook/phabricator/issues/467. @dctrwatson also ran into an issue where we were trying to setPass() a GitURI.

For Git and Mercurial, properly generate credential URIs where relevant.
Don't try to setPass() on Git-style URIs.

This isn't perfect but should clean things up a bit.

Test Plan

Added unit tests. Lots of grep.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Dec 12 2013, 12:38 AM

Add more tests.
Ran pull/discover against an HTTP auth remote.

Closed by commit rPd846f6508b2c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

scripts/

repository/

test_connection.php

93 lines

src/

__phutil_library_map__.php

2 lines

applications/

drydock/

blueprint/

DrydockWorkingCopyBlueprintImplementation.php

4 lines

repository/

daemon/

PhabricatorRepositoryPullLocalDaemon.php

4 lines

engine/

PhabricatorRepositoryPullEngine.php

8 lines

storage/

PhabricatorRepository.php

52 lines

__tests__/

PhabricatorRepositoryURITestCase.php

95 lines

Diff 17553

scripts/repository/test_connection.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/drydock/blueprint/DrydockWorkingCopyBlueprintImplementation.php

Loading...

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...

src/applications/repository/storage/tests/PhabricatorRepositoryURITestCase.php

Loading...