Page MenuHomePhabricator

Fix some repository URI handling issues in Git and Mercurial
ClosedPublic

Authored by epriestley on Dec 12 2013, 12:30 AM.
Tags
None
Referenced Files
F13302858: D7759.diff
Sat, Jun 8, 5:55 AM
F13287928: D7759.diff
Tue, Jun 4, 9:32 AM
F13275703: D7759.diff
Fri, May 31, 5:05 AM
F13262436: D7759.diff
Mon, May 27, 2:08 AM
F13217926: D7759.id17552.diff
Sat, May 18, 9:04 AM
F13217925: D7759.id17553.diff
Sat, May 18, 9:04 AM
F13217924: D7759.id17550.diff
Sat, May 18, 9:04 AM
F13217764: D7759.diff
Sat, May 18, 7:57 AM
Subscribers

Details

Summary

See https://github.com/facebook/phabricator/issues/467. @dctrwatson also ran into an issue where we were trying to setPass() a GitURI.

  • For Git and Mercurial, properly generate credential URIs where relevant.
  • Don't try to setPass() on Git-style URIs.

This isn't perfect but should clean things up a bit.

Test Plan

Added unit tests. Lots of grep.

Diff Detail

Branch
repouri
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Dec 12 2013, 5:45 PM
  • Add more tests.
  • Ran pull/discover against an HTTP auth remote.