HomePhabricator

Make sure no one ever misunderstand the "unkonwn symbol" lint message ever again
e0b4eef9de17Unpublished

Unpublished Commit · Learn More

No further details are available.

Description

Make sure no one ever misunderstand the "unkonwn symbol" lint message ever again

Summary: A lot of new contributors don't resolve this. Make it easier to resolve, more comprehensive, and more explicit about not being ignorable.

Test Plan:

>>> orbital ~/devtools/arcanist $ arc lint
>>> Lint for src/lint/linter/ArcanistPhutilLibraryLinter.php:

   Error  (PHL1) Unknown Symbol
    Use of unknown class 'BlerpBarp'. Common causes are:

      - Your libphutil/ is out of date.
        This is the most common cause.
        Update this copy of libphutil: /INSECURE/devtools/libphutil

      - Some other library is out of date.
        Update the library this symbol appears in.

      - This symbol is misspelled.
        Spell the symbol name correctly.
        Symbol name spelling is case-sensitive.

      - This symbol was added recently.
        Run `arc liberate` on the library it was added to.

      - This symbol is external. Use `@phutil-external-symbol`.
        Use `grep` to find usage examples of this directive.

    *** ALTHOUGH USUALLY EASY TO FIX, THIS IS A SERIOUS ERROR.
    *** THIS ERROR IS YOUR FAULT. YOU MUST RESOLVE IT.

             181               "*** THIS ERROR IS YOUR FAULT. YOU MUST RESOLVE IT.");
             182
             183             if (false) {
    >>>      184               new BlerpBarp();
             185             }
             186           }
             187         }
>>> orbital ~/devtools/arcanist $

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7752

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Dec 10 2013, 4:33 PM
Reviewer
chad
Differential Revision
D7752: Make sure no one ever misunderstand the "unkonwn symbol" lint message ever again
Parents
rARC4fdb87761bce: Fix working copy binding powers in weird edge cases
Branches
Unknown
Tags
Unknown

Event Timeline