Page MenuHomePhabricator

plug octocat icon to landing button
ClosedPublic

Authored by avivey on Dec 9 2013, 8:31 PM.
Tags
None
Referenced Files
F14065958: D7749.diff
Tue, Nov 19, 7:25 AM
F14052001: D7749.diff
Fri, Nov 15, 5:43 AM
F14048084: D7749.id17522.diff
Thu, Nov 14, 6:44 AM
F14043956: D7749.diff
Tue, Nov 12, 2:15 PM
F14041561: D7749.id17518.diff
Mon, Nov 11, 7:39 PM
F14040451: D7749.diff
Mon, Nov 11, 10:24 AM
F14022785: D7749.diff
Wed, Nov 6, 7:43 PM
F14022775: D7749.id17522.diff
Wed, Nov 6, 7:30 PM

Details

Test Plan

look at shiny button

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

The id() is unnecessary -- you only need that when using new. Oh, PHP.

I do not know why I didn't try this. Thanks!

(I'll pull this in a second, just popping my queue.)

Closed by commit rPde969ab54011 (authored by Aviv Eyal <aeyal@groupon.com>, committed by @epriestley).