Page MenuHomePhabricator

plug octocat icon to landing button
ClosedPublic

Authored by avivey on Dec 9 2013, 8:31 PM.
Tags
None
Referenced Files
F15411968: D7749.diff
Wed, Mar 19, 10:34 AM
Unknown Object (File)
Feb 24 2025, 11:19 AM
Unknown Object (File)
Feb 1 2025, 9:44 AM
Unknown Object (File)
Jan 29 2025, 1:46 AM
Unknown Object (File)
Jan 28 2025, 8:34 AM
Unknown Object (File)
Jan 23 2025, 1:39 AM
Unknown Object (File)
Jan 13 2025, 9:11 AM
Unknown Object (File)
Jan 2 2025, 5:02 AM

Details

Test Plan

look at shiny button

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

The id() is unnecessary -- you only need that when using new. Oh, PHP.

I do not know why I didn't try this. Thanks!

(I'll pull this in a second, just popping my queue.)

Closed by commit rPde969ab54011 (authored by Aviv Eyal <aeyal@groupon.com>, committed by @epriestley).