Page MenuHomePhabricator

plug octocat icon to landing button
ClosedPublic

Authored by avivey on Dec 9 2013, 8:31 PM.
Tags
None
Referenced Files
F18646727: D7749.diff
Sep 19 2025, 10:59 AM
F18612984: D7749.diff
Sep 14 2025, 10:30 AM
F18329317: D7749.id17522.diff
Aug 25 2025, 12:17 AM
F18082208: D7749.diff
Aug 5 2025, 4:40 AM
F17988365: D7749.id17522.diff
Aug 1 2025, 11:03 PM
F17947702: D7749.id.diff
Jul 31 2025, 6:02 PM
F17934891: D7749.diff
Jul 30 2025, 10:54 PM
Unknown Object (File)
Jun 18 2025, 4:56 PM

Details

Test Plan

look at shiny button

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

The id() is unnecessary -- you only need that when using new. Oh, PHP.

I do not know why I didn't try this. Thanks!

(I'll pull this in a second, just popping my queue.)

Closed by commit rPde969ab54011 (authored by Aviv Eyal <aeyal@groupon.com>, committed by @epriestley).