Page MenuHomePhabricator

Work around broken PHP fwrite() on nonblocking pipes
ClosedPublic

Authored by epriestley on Dec 9 2013, 4:35 PM.
Tags
None
Referenced Files
F18877700: D7748.id.diff
Thu, Nov 6, 11:30 AM
F18856560: D7748.id.diff
Sat, Nov 1, 10:20 AM
F18855239: D7748.id17521.diff
Sat, Nov 1, 4:29 AM
F18852537: D7748.diff
Fri, Oct 31, 9:53 AM
F18821487: D7748.id17515.diff
Wed, Oct 22, 11:39 PM
F18737327: D7748.id.diff
Oct 1 2025, 10:12 AM
F18728734: D7748.diff
Sep 30 2025, 9:46 AM
F18728068: D7748.id17521.diff
Sep 30 2025, 9:04 AM
Subscribers

Details

Summary

Fixes T4219. See comments. PHP returns 0 when writing to nonblocking pipes for both "everything is OK, but this pipe is blocked, so you should wait a little bit and try again" and "nothing is OK, this pipe is broken forever".

This was causing an busy loop in ssh-exec, where it would check if stderr was writable, see it was, try to write to it, get a 0-length write, interpret that as "wait a bit", wait for it to become writable (i.e., immediately!), try to write again, etc.

This was the best workaround I could come up with. I think it should be pretty safe; I'm not aware of any temporary condition or event which can make a pipe unwritable after a select says it's writable other than a write.

Test Plan

Ran git pull a bunch of times and ^C'd it partway through. Previously I could leave a busy process eating a CPU on the server about 50% of the time, depending how good my timing was. I can no longer generate these processes.

Diff Detail

Branch
epipe
Lint
Lint Passed
Unit
Tests Passed